Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linker isn't removing references to WPF from a WinForms app #832

Closed
sbomer opened this issue Nov 26, 2019 · 1 comment
Closed

Linker isn't removing references to WPF from a WinForms app #832

sbomer opened this issue Nov 26, 2019 · 1 comment

Comments

@sbomer
Copy link
Member

sbomer commented Nov 26, 2019

As mentioned in dotnet/winforms#2426, the self-contained publish output of a WinForms app will include WPF assemblies.

If this issue isn't solved on the SDK/winforms side, we should consider whether the linker can help trim those unused references. The sample shared in that issue has a publish profile with PublishTrimmed but the WPF assemblies were still kept - which makes sense given that the 3.0 defaults for the linker keep everything outside of netcoreapp.

If that gets solved on the SDK side, we can probably just close this.

@vitek-karas
Copy link
Member

I think it's better to track this on the winforms side: dotnet/winforms#3723
If there's a specific ask on linker as part of the bigger solution, then it should be created as a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants