Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples with Object Pooling of PredictionFunction objects when scoring in ASP.NET Core apps #147

Closed
CESARDELATORRE opened this issue Nov 30, 2018 · 2 comments
Assignees

Comments

@CESARDELATORRE
Copy link
Contributor

Related to this issue at ML.NET: dotnet/machinelearning#1789 (comment) and the discussions here: dotnet/machinelearning#1718

All the Web based end-user apps using ASP.NET Core should follow a similar approach:

  • eShopDashboard - Sales Forecast
  • Movies recommender
  • Any other ASP.NETCore MVC, Razor or Web API sample
@CESARDELATORRE CESARDELATORRE self-assigned this Nov 30, 2018
@CESARDELATORRE
Copy link
Contributor Author

@shmoradims - I just implemented sample code on how to use object pooling for the PredictionFunction / PredictionEngine objects in this PR for the ASP.NET Core web app eShopDashboardML, here:

#184

However, after creating the code which I find very generic and usable for any end-user app while at the same time it is significant code to create/understand, I still think that this kind of implementation/code should be part of ML.NET API not really part of user's code.

We need to have a further discussion about it reviewing the code I wrote for this approach. 👍

@CESARDELATORRE
Copy link
Contributor Author

Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant