Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CollectionView virtualization does not work when using a DataTemplateSelector #11272

Closed
tranb3r opened this issue Nov 10, 2022 · 3 comments · Fixed by #12011
Closed

CollectionView virtualization does not work when using a DataTemplateSelector #11272

tranb3r opened this issue Nov 10, 2022 · 3 comments · Fixed by #12011
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView fixed-in-8.0.0-preview.5.8529 Look for this fix in 8.0.0-preview.5.8529! platform/android 🤖 platform/iOS 🍎 t/bug Something isn't working t/perf The issue affects performance (runtime speed, memory usage, startup time, etc.) (sub: perf)

Comments

@tranb3r
Copy link

tranb3r commented Nov 10, 2022

Description

CollectionView virtualization does not work when using a DataTemplateSelector.
Both on android and ios.
Both on xamarin-forms and dotnet-maui.

I think this is a serious performance issue.
I've already reported this issue here with full details.
Could anybody help ?

Steps to Reproduce

  1. Run app from the repro project (either xamarin forms or maui, both for ios and android)
  2. Click on the Add button
  3. Scroll down/up a bit, and observe the increase of counters.
  4. Compare the performance of different collection types on each tab.

Link to public reproduction project repository

...

Version with bug

6.0.486 (current)

Last version that worked well

Unknown/Other

Affected platforms

iOS, Android

Affected platform versions

All

Did you find any workaround?

No response

Relevant log output

No response

@tranb3r tranb3r added the t/bug Something isn't working label Nov 10, 2022
@Eilon Eilon added the area-controls-collectionview CollectionView, CarouselView, IndicatorView label Nov 10, 2022
@jsuarezruiz jsuarezruiz added the legacy-area-perf Startup / Runtime performance label Nov 11, 2022
@PureWeen PureWeen added this to the Backlog milestone Nov 11, 2022
@ghost
Copy link

ghost commented Nov 11, 2022

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@tranb3r
Copy link
Author

tranb3r commented Dec 1, 2022

Could someone please investigate ?
cc @jonathanpeppers : this bug is quite a serious performance issue, I'm sure it's worth fixing it if you have the time to work on it.
Thanks.

@Vroomer
Copy link

Vroomer commented Apr 5, 2023

@Redth Can you please let us know when we can expect the fix? You made PR 4 months ago and to this day it hasn't been merged without any further information. Selector is essential for any complex CollectionView and there is no workaround without massive performance hit. Combined with #12988 there is 7 unique likes so it seems to be among more important issues affecting a lot of developers. It's blocking us and it's been very frustrating to wait this long. Fix to this issue would be really appreciated.

@samhouts samhouts modified the milestones: Backlog, .NET 8 May 24, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.5.8529 Look for this fix in 8.0.0-preview.5.8529! label Jun 21, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 22, 2023
@Eilon Eilon added t/perf The issue affects performance (runtime speed, memory usage, startup time, etc.) (sub: perf) and removed legacy-area-perf Startup / Runtime performance labels May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView fixed-in-8.0.0-preview.5.8529 Look for this fix in 8.0.0-preview.5.8529! platform/android 🤖 platform/iOS 🍎 t/bug Something isn't working t/perf The issue affects performance (runtime speed, memory usage, startup time, etc.) (sub: perf)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants