Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Rework SetVirtualView so when called via the interface it won't call the abstract SetVirtualView #1213

Closed
PureWeen opened this issue Jun 8, 2021 · 1 comment
Closed

[Bug] Rework SetVirtualView so when called via the interface it won't call the abstract SetVirtualView #1213

PureWeen opened this issue Jun 8, 2021 · 1 comment
Assignees
@PureWeen
Labels
t/bug Something isn't working

Comments

@PureWeen
Copy link
Member

PureWeen commented Jun 8, 2021

In order to do this we'll probably need to change the overridable name of SetVirtualView to SetVirtualViewCore

I checked in a fix here so that we don't call SetVirtualView when we don't need to but making this check a feature of SetVirtualView on the ViewHandler would probably be preferred

#1212
@PureWeen PureWeen added the t/bug Something isn't working label Jun 8, 2021
@PureWeen PureWeen self-assigned this Jun 8, 2021
@PureWeen PureWeen mentioned this issue Jun 8, 2021
Merged
@jsuarezruiz
Copy link
Contributor

Already done.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@PureWeen PureWeen

Labels
t/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PureWeen @jsuarezruiz