Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UITEST] CollectionView Enable Legacy Tests #19050

Closed
15 of 17 tasks
jfversluis opened this issue Nov 27, 2023 · 6 comments · Fixed by #18979
Closed
15 of 17 tasks

[UITEST] CollectionView Enable Legacy Tests #19050

jfversluis opened this issue Nov 27, 2023 · 6 comments · Fixed by #18979
Assignees
@jfversluis @jsuarezruiz
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView area-testing Unit tests, device tests fixed-in-8.0.60 fixed-in-9.0.0-preview.5.24307.10 testing-legacy-ui-tests Issues/PRs that are associated with transitioning our legacy UI Tests to Appium
Milestone
.NET 8 SR6

Comments

@jfversluis
Copy link
Member

jfversluis commented Nov 27, 2023 •
edited by jsuarezruiz
Loading

Below are all the (legacy) UI tests identified as being a part of the tests that cover CollectionView and have been disabled at this time. These should al be reenabled by checking if the test (still) fails and if yes, fix it one way or the other.

Note that there might be more tests associated to this area that haven't been properly identified yet. Feel free to also include those and please add them here.

iOS

  • CollectionViewBindingErrorsShouldBeZero (src\Compatibility\ControlGallery\src\Issues.Shared\CollectionViewBindingErrors.xaml.cs)
  • ItemsFromViewModelShouldBeSelected (src\Compatibility\ControlGallery\src\Issues.Shared\CollectionViewBoundMultiSelection.cs)
  • CollectionViewItemsSourceTypesDisplayAndDontCrash (src\Compatibility\ControlGallery\src\Issues.Shared\CollectionViewItemsSourceTypes.cs)
  • KeepScrollOffset (src\Compatibility\ControlGallery\src\Issues.Shared\CollectionViewItemsUpdatingScrollMode.cs)
  • KeepLastItemInView(src\Compatibility\ControlGallery\src\Issues.Shared\CollectionViewItemsUpdatingScrollMode.cs)
  • CollectionViewItemsLayoutUpdate (src\Compatibility\ControlGallery\src\Issues.Shared\Issue5354.xaml.cs)
  • ClearingGroupedCollectionViewShouldNotCrash (src\Compatibility\ControlGallery\src\Issues.Shared\Issue8899.cs)
  • EmptyViewShouldNotCrash (src\Compatibility\ControlGallery\src\Issues.Shared\Issue9196.xaml.cs)
  • InitiallyInvisbleCollectionViewSurvivesiOSLayoutNonsense(src\Compatibility\ControlGallery\src\Issues.Shared\Issue12714.cs)
  • CollectionViewShouldSourceShouldResetWhileInvisible (src\Compatibility\ControlGallery\src\Issues.Shared\Issue13126_2.cs)
  • CollectionViewShouldSourceShouldUpdateWhileInvisible (src\Compatibility\ControlGallery\src\Issues.Shared\Issue13126.cs)
  • CollectionShouldInvalidateOnVisibilityChange (src\Compatibility\ControlGallery\src\Issues.Shared\Issue13203.cs)
  • VisitAndUpdateItemsSource (src\Compatibility\ControlGallery\src\UITests.Shared\Tests\CollectionViewUITests.cs)

Android

  • SelectionShouldUpdateBinding (src\Compatibility\ControlGallery\src\Issues.Shared\CollectionViewBoundSingleSelection.cs)
  • CollectionViewInfiniteScroll (src\Compatibility\ControlGallery\src\Issues.Shared\Github5623.xaml.cs)
  • AddingItemToUnviewedCollectionViewShouldNotCrash (src\Compatibility\ControlGallery\src\Issues.Shared\Issue7700.cs)
  • AddingGroupToUnviewedGroupedCollectionViewShouldNotCrash (src\Compatibility\ControlGallery\src\Issues.Shared\Issue7700.cs)
@jfversluis jfversluis added area-controls-collectionview CollectionView, CarouselView, IndicatorView area-testing Unit tests, device tests labels Nov 27, 2023
@tjiakwokyung28

This comment was marked as off-topic.

Sign in to view
@PureWeen PureWeen added this to the .NET 8 + Servicing milestone Nov 27, 2023
@jfversluis jfversluis added the testing-legacy-ui-tests Issues/PRs that are associated with transitioning our legacy UI Tests to Appium label Nov 28, 2023
@jsuarezruiz jsuarezruiz mentioned this issue Nov 28, 2023
Merged
@jsuarezruiz
Copy link
Contributor

CollectionViewItemsLayoutUpdate (src\Compatibility\ControlGallery\src\Issues.Shared\Issue5354.xaml.cs) requires DragCoordinates https://learn.microsoft.com/en-us/dotnet/api/xamarin.uitest.iapp.dragcoordinates?view=xamarin-uitest-sdk

@jsuarezruiz
Copy link
Contributor

CollectionViewItemsLayoutUpdate (src\Compatibility\ControlGallery\src\Issues.Shared\Issue5354.xaml.cs) requires DragCoordinates https://learn.microsoft.com/en-us/dotnet/api/xamarin.uitest.iapp.dragcoordinates?view=xamarin-uitest-sdk

Added here #19333

@jsuarezruiz
Copy link
Contributor

Issue5354 and Github5623 requires the usage of the still not implemented QueryUntilPresent emthod.

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Dec 18, 2023 •
edited
Loading

CarouselView Legacy tests

  • Issue10300(src\Compatibility\ControlGallery\src\UITests.Shared\Tests\Issue10300.cs)
  • Issue11224(src\Compatibility\ControlGallery\src\UITests.Shared\Tests\Issue11224.cs)
  • Issue12193(src\Compatibility\ControlGallery\src\UITests.Shared\Tests\Issue12193.cs)
  • Issue12574 (src\Compatibility\ControlGallery\src\UITests.Shared\Tests\Issue12574.cs)
  • Issue12777(src\Compatibility\ControlGallery\src\UITests.Shared\Tests\Issue12777.cs)
  • Issue12848(src\Compatibility\ControlGallery\src\UITests.Shared\Tests\Issue12848.cs)
  • Issue13436(src\Compatibility\ControlGallery\src\UITests.Shared\Tests\Issue13436.cs)
  • Issue7803(src\Compatibility\ControlGallery\src\UITests.Shared\Tests\Issue7803.cs)
  • Issue9827(src\Compatibility\ControlGallery\src\UITests.Shared\Tests\Issue9827.cs)

@jsuarezruiz
Copy link
Contributor

Issue7803 requires the usage of the still not implemented QueryUntilPresent method.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jfversluis jfversluis

@jsuarezruiz jsuarezruiz

Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView area-testing Unit tests, device tests fixed-in-8.0.60 fixed-in-9.0.0-preview.5.24307.10 testing-legacy-ui-tests Issues/PRs that are associated with transitioning our legacy UI Tests to Appium
Projects
None yet
Milestone
.NET 8 SR6
Development

Successfully merging a pull request may close this issue.

[Testing] Add legacy CollectionView UITests dotnet/maui
5 participants
@jfversluis @PureWeen @jsuarezruiz @samhouts @tjiakwokyung28