Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NET 8 :: Sizing of windows, text buttons and icon buttons are off #21285

Closed
linkaiyu opened this issue Mar 18, 2024 · 2 comments · Fixed by #22476
Closed

NET 8 :: Sizing of windows, text buttons and icon buttons are off #21285

linkaiyu opened this issue Mar 18, 2024 · 2 comments · Fixed by #22476
Assignees
@tj-devel709
Labels
area-controls-button Button, ImageButton fixed-in-8.0.90 fixed-in-9.0.0-rc.2.24503.2 partner/cat 😻 this is an issue that impacts one of our partners or a customer our advisory team is engaged with partner/macios Issues for the Mac / iOS SDK platform/macOS 🍏 macOS / Mac Catalyst s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone
.NET 8 SR9

Comments

@linkaiyu
Copy link

linkaiyu commented Mar 18, 2024 •
edited by PureWeen
Loading

Description

After upgrading to NET8.0.10 (from Net7), sizing of buttons with text and icons appears to be changed. In Net7, when a button has image and text, the image would scale when the size of button changes, but in NET8.0.10 the image would get cropped on Mac. (it is not a problem on Windows)

Steps to Reproduce

use this xaml to see the difference between Net7 and Net8.0.10 on Mac

<Button Text="Button" ImageSource="watchlist.png" MinimumWidthRequest="1" MinimumHeightRequest="1" WidthRequest="100" HeightRequest="32" BackgroundColor="Gray" Padding="11,9,0,9" />

Link to public reproduction project repository

No response

Version with bug

8.0.7 SR2

Is this a regression from previous behavior?

No, this is something new

Last version that worked well

7.0.100

Affected platforms

macOS

Affected platform versions

No response

Did you find any workaround?

No response

Relevant log output

No response
@linkaiyu linkaiyu added the t/bug Something isn't working label Mar 18, 2024
@PureWeen PureWeen added this to the .NET 8 SR4 milestone Mar 18, 2024
@PureWeen PureWeen added partner/cat 😻 this is an issue that impacts one of our partners or a customer our advisory team is engaged with partner/macios Issues for the Mac / iOS SDK s/needs-repro Attach a solution or code which reproduces the issue labels Mar 18, 2024
@linkaiyu
Copy link
Author

link to repro
https://github.com/linkaiyu/MauiNet8-0-10

@dotnet-policy-service dotnet-policy-service bot added s/needs-attention Issue has more information and needs another look and removed s/needs-repro Attach a solution or code which reproduces the issue labels Mar 18, 2024
@ninachen03 ninachen03 added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Mar 19, 2024
@ninachen03
Copy link

Verified on VS for Mac 17.6.10 build 428 and Microsoft.Maui.Controls is 8.0.20-nightly.10326+sha.23171190fc-azdo.9256731 , can repro it on MacCatalyst platform.
image

@PureWeen PureWeen moved this from Todo to In Progress in MAUI SDK Ongoing Mar 20, 2024
@samhouts samhouts added the platform/macOS 🍏 macOS / Mac Catalyst label Mar 22, 2024
@PureWeen PureWeen removed the s/needs-attention Issue has more information and needs another look label Mar 31, 2024
@PureWeen PureWeen modified the milestones: .NET 8 SR4, .NET 8 SR5 Apr 18, 2024
@PureWeen PureWeen modified the milestones: .NET 8 SR5, .NET 8 SR6 May 10, 2024
@PureWeen PureWeen added the area-controls-button Button, ImageButton label May 15, 2024
@PureWeen PureWeen assigned mattleibow and unassigned Foda May 31, 2024
@PureWeen PureWeen modified the milestones: .NET 8 SR6, .NET 8 SR7 Jun 3, 2024
@PureWeen PureWeen assigned tj-devel709 and unassigned mattleibow Jun 15, 2024
@samhouts samhouts removed s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Jul 3, 2024
@PureWeen PureWeen modified the milestones: .NET 8 SR7, .NET 8 SR8 Jul 5, 2024
@PureWeen PureWeen mentioned this issue Jul 10, 2024
Merged
@samhouts samhouts added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Jul 10, 2024
@PureWeen PureWeen modified the milestones: .NET 8 SR8, .NET 8 SR9 Aug 2, 2024
@github-project-automation github-project-automation bot moved this from Ready To Review to Done in MAUI SDK Ongoing Aug 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tj-devel709 tj-devel709

Labels
area-controls-button Button, ImageButton fixed-in-8.0.90 fixed-in-9.0.0-rc.2.24503.2 partner/cat 😻 this is an issue that impacts one of our partners or a customer our advisory team is engaged with partner/macios Issues for the Mac / iOS SDK platform/macOS 🍏 macOS / Mac Catalyst s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
MAUI SDK Ongoing
Status: Done
Milestone
.NET 8 SR9
Development

Successfully merging a pull request may close this issue.

[iOS] Fix Button image sizing and layout dotnet/maui
7 participants
@Foda @mattleibow @PureWeen @samhouts @linkaiyu @tj-devel709 @ninachen03