Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flyout margins and settings do not display correctly #4762

Closed
mobycorp opened this issue Feb 17, 2022 · 4 comments
Closed

Flyout margins and settings do not display correctly #4762

mobycorp opened this issue Feb 17, 2022 · 4 comments
Assignees
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout p/0 Work that we can't release without platform/windows 🪟 s/needs-verification Indicates that this issue needs initial verification before further triage will happen t/bug Something isn't working
Milestone

Comments

@mobycorp
Copy link

Description

I have a simple flyout with a header and several pages defined in a shell xaml file. One of these issues has been present in both preview 12 and preview 13 and the other issue broke in preview 13. For reference, here is the top bit of the shell xaml file...

image

I am setting Flyout width to 210 pixels. When the app is first fired up, the width setting is not honored as shown in the next screenshot. Also notice the placement of the flyout header and tab headers. They are evenly spaced from the top of the window. This broke in preview 13.

Flyout width incorrect - flyout header margin correct - preview 12

You can see the width of the flyout is set to the default width and the 210 pixel setting is not being calculated. If you simply change the page, the width is then properly calculated as shown in the next screenshot.

Flyout width correct after page change

The flyout margin issue started in preview 13. In preview 12 it was fine.

Steps to Reproduce

  1. Create a new .NET Maui project
  2. Create a layout with the code from above. Include at least two pages of shell content.
  3. Fire the app up. The flyout width will be incorrect.
  4. Change the page tab. The flyout width will then be recalculated and display correctly.

Version with bug

Preview 13 (current)

Last version that worked well

Unknown/Other

Affected platforms

Windows

Affected platform versions

Dependency net6.0-windows10.0.19041

Did you find any workaround?

No

Relevant log output

N/A
@mobycorp mobycorp added the t/bug Something isn't working label Feb 17, 2022
@jsuarezruiz jsuarezruiz added the area-controls-shell Shell Navigation, Routes, Tabs, Flyout label Feb 18, 2022
@wenwen60
Copy link

wenwen60 commented Mar 2, 2022

Reproduce on windows using VS2022(17.2.0 Preview 2.0), attach repro sample
4762.zip.

@wenwen60 wenwen60 added the s/verified Verified / Reproducible Issue ready for Engineering Triage label Mar 2, 2022
@PureWeen PureWeen added this to the 6.0.300-rc.2 milestone Mar 22, 2022
@PureWeen
Copy link
Member

This is most likely related to this issue
#4719

it seems like the new layouts don't take into account the margin when setting the frame or the code being used in ListView / Shell to measure is incorrect

@PureWeen PureWeen modified the milestones: 6.0.300-rc.2, 6.0.300-rc.3 Apr 19, 2022
@Redth Redth modified the milestones: 6.0.300-rc.3, 6.0.300 Apr 27, 2022
@davidortinau davidortinau added s/needs-verification Indicates that this issue needs initial verification before further triage will happen p/0 Work that we can't release without and removed s/verified Verified / Reproducible Issue ready for Engineering Triage labels Apr 29, 2022
@davidortinau
Copy link
Contributor

Given recent related fixes, this needs to be revalidated.

@Redth Redth self-assigned this Apr 29, 2022
@Redth
Copy link
Member

Redth commented Apr 29, 2022

This appears to be fixed in main:
image

@Redth Redth closed this as completed Apr 29, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout p/0 Work that we can't release without platform/windows 🪟 s/needs-verification Indicates that this issue needs initial verification before further triage will happen t/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants