Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Reduce the wrapping around SDK Resolver messages when only one resolver is actually invoked #10191

Open
baronfel opened this issue May 30, 2024 · 1 comment
Labels
Area: Logging Area: Resolvers Feature Request Good First Issue Self-contained issues good for first-time contributors. internal-team-onboarding Priority:2 Work that is important, but not critical for the release triaged

Comments

@baronfel
Copy link
Member

Summary

In dotnet/sdk#41268 I was able to use the SDK Resolver features to ensure that only the NuGet SDK resolver was used for a restore. In this case we should be able to remove MSBuild wrapping around the 'error list' and only surface the single Resolver's message.

Background and Motivation

We want to remove visual noise around error experiences and make it easier for users to diagnose the core problems.

Proposed Feature

if (failOnUnresolvedSdk)
{
loggingContext.LogError(new BuildEventFileInfo(sdkReferenceLocation), "FailedToResolveSDK", sdk.Name, string.Join($"{Environment.NewLine} ", errors));
}
should change the way it logs to not log the wrapper if only one resolver was used.

Alternative Designs

No response

@AR-May
Copy link
Member

AR-May commented Jun 4, 2024

Makes sense to me. A small change in logging.

@AR-May AR-May added Good First Issue Self-contained issues good for first-time contributors. Area: Logging Priority:2 Work that is important, but not critical for the release internal-team-onboarding labels Jun 4, 2024
@AR-May AR-May assigned JaynieBai and unassigned JaynieBai Jun 4, 2024
@AR-May AR-May added the triaged label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Logging Area: Resolvers Feature Request Good First Issue Self-contained issues good for first-time contributors. internal-team-onboarding Priority:2 Work that is important, but not critical for the release triaged
Projects
None yet
Development

No branches or pull requests

3 participants