Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API to find dotnet host executable #9018

Open
rainersigwald opened this issue Jul 12, 2023 · 0 comments
Open

API to find dotnet host executable #9018

rainersigwald opened this issue Jul 12, 2023 · 0 comments
Labels
backlog Priority:2 Work that is important, but not critical for the release triaged

Comments

@rainersigwald
Copy link
Member

rainersigwald commented Jul 12, 2023 •
edited
Loading

Historically our guidance (given to us by other teams) was to try to not parse PATH and make sense out of it

Yeah I'm not really thrilled about parsing $PATH either. Ended up just stealing the code from msbuild that does it. This is essentially how our entire build tool stack works today so it seems like a good source to draw some.

Would be nice to have an API for FindOnPath but that seems unlikely. Also I'd still have to polyfill that for downlevel targets.

@rainersigwald, @baronfel: have you all ever considered exposing a FindToolPath on ToolTask or MSBuild APIs in general that we could use to find dotnet? That way the logic for parsing $PATH is centralized.

Originally posted by @jaredpar in dotnet/runtime#88754 (comment)
@rainersigwald rainersigwald mentioned this issue Jul 12, 2023
Open
@rainersigwald rainersigwald added the needs-triage Have yet to determine what bucket this goes in. label Jul 12, 2023
@AR-May AR-May added Priority:2 Work that is important, but not critical for the release backlog and removed needs-triage Have yet to determine what bucket this goes in. labels Jul 18, 2023
@eerhardt eerhardt mentioned this issue Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Priority:2 Work that is important, but not critical for the release triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rainersigwald @JaynieBai @AR-May