Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Windows/x64: 5 Regressions on 4/12/2023 8:39:35 PM #16326

Closed
performanceautofiler bot opened this issue Apr 18, 2023 · 1 comment
Closed

[Perf] Windows/x64: 5 Regressions on 4/12/2023 8:39:35 PM #16326

performanceautofiler bot opened this issue Apr 18, 2023 · 1 comment

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Apr 18, 2023

Run Information

Name Value
Architecture x64
OS Windows 10.0.18362
Queue TigerWindows
Baseline e7ed417c2bf4a24a0694a387f33ba843a2318fdc
Compare f92b9ef636a4cc9599b33446e30e7a489591ca46
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Tests.Perf_Single

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
ToStringWithFormat - Duration of single invocation 174.39 ns 183.18 ns 1.05 0.02 False Trace Trace
ToStringWithFormat - Duration of single invocation 208.45 ns 228.31 ns 1.10 0.00 False Trace Trace
ToString - Duration of single invocation 172.01 ns 181.56 ns 1.06 0.02 False 1483.1073284471713 1526.728043077449 1.0294117045972317) Trace Trace
ToStringWithFormat - Duration of single invocation 206.50 ns 226.19 ns 1.10 0.01 False 1759.2487704492462 1817.3621844410097 1.0330330848984612) Trace Trace
ToStringWithFormat - Duration of single invocation 172.10 ns 182.99 ns 1.06 0.01 False Trace Trace

graph
graph
graph
graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

Payloads

Baseline
Compare

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Tests.Perf_Single*'

Payloads

Baseline
Compare

Histogram

System.Tests.Perf_Single.ToStringWithFormat(value: 3.4028235E+38, format: "R")


Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 183.18098328399165 > 182.86223498204842.
IsChangePoint: Marked as a change because one of 3/17/2023 10:06:19 AM, 4/12/2023 4:44:56 PM, 4/17/2023 11:29:15 PM falls between 4/9/2023 11:24:15 AM and 4/17/2023 11:29:15 PM.
IsRegressionStdDev: Marked as regression because -17.18153646679879 (T) = (0 -184.2949237149595) / Math.Sqrt((3.6278340045107633 / (33)) + (0.7212425266862946 / (4))) is less than -2.0301079282477414 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (33) + (4) - 2, .025) and -0.05288236211719957 = (175.03847566063138 - 184.2949237149595) / 175.03847566063138 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Baseline JIT Disasm

Complete output

Compare JIT Disasm

Complete output

JIT Disasm Diff

Link

System.Tests.Perf_Single.ToStringWithFormat(value: -3.4028235E+38, format: "G17")


Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 228.30868034213563 > 218.67145089518388.
IsChangePoint: Marked as a change because one of 4/12/2023 8:39:35 PM, 4/17/2023 11:29:15 PM falls between 4/9/2023 11:24:15 AM and 4/17/2023 11:29:15 PM.
IsRegressionStdDev: Marked as regression because -7.091992657232193 (T) = (0 -235.9949600270185) / Math.Sqrt((1.5201258220134337 / (34)) + (47.314311190116996 / (3))) is less than -2.0301079282477414 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (34) + (3) - 2, .025) and -0.13573537379720668 = (207.79044614767542 - 235.9949600270185) / 207.79044614767542 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Baseline JIT Disasm

Complete output

Compare JIT Disasm

Complete output

JIT Disasm Diff

Link

System.Tests.Perf_Single.ToString(value: -3.4028235E+38)


Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 181.55502228615939 > 180.57587943359172.
IsChangePoint: Marked as a change because one of 3/25/2023 10:49:06 AM, 4/12/2023 8:39:35 PM, 4/17/2023 11:29:15 PM falls between 4/9/2023 11:24:15 AM and 4/17/2023 11:29:15 PM.
IsRegressionStdDev: Marked as regression because -10.088801031936988 (T) = (0 -183.23074535411538) / Math.Sqrt((4.955921061201516 / (34)) + (2.154373823286651 / (3))) is less than -2.0301079282477414 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (34) + (3) - 2, .025) and -0.053936678049342 = (173.85365664780204 - 183.23074535411538) / 173.85365664780204 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Baseline JIT Disasm

Complete output

Compare JIT Disasm

Complete output

JIT Disasm Diff

Link

System.Tests.Perf_Single.ToStringWithFormat(value: 3.4028235E+38, format: "G17")


Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 226.19373675815802 > 216.1650776510515.
IsChangePoint: Marked as a change because one of 4/12/2023 8:39:35 PM, 4/17/2023 11:29:15 PM falls between 4/9/2023 11:24:15 AM and 4/17/2023 11:29:15 PM.
IsRegressionStdDev: Marked as regression because -4.666839665361526 (T) = (0 -231.81093524362348) / Math.Sqrt((1.2505030730251219 / (33)) + (63.1058376502304 / (2))) is less than -2.034515297446192 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (33) + (2) - 2, .025) and -0.12759130520831455 = (205.58063384569823 - 231.81093524362348) / 205.58063384569823 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Baseline JIT Disasm

Complete output

Compare JIT Disasm

Complete output

JIT Disasm Diff

Link

System.Tests.Perf_Single.ToStringWithFormat(value: 3.4028235E+38, format: "G")


Description of detection logic

IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 182.98930486043295 > 180.84552291835843.
IsChangePoint: Marked as a change because one of 3/6/2023 6:03:21 AM, 3/17/2023 5:15:23 PM, 4/12/2023 8:39:35 PM, 4/17/2023 11:29:15 PM falls between 4/9/2023 11:24:15 AM and 4/17/2023 11:29:15 PM.
IsRegressionStdDev: Marked as regression because -12.669553429308806 (T) = (0 -184.2738732741128) / Math.Sqrt((4.426139222496169 / (34)) + (1.8329622292903862 / (3))) is less than -2.0301079282477414 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (34) + (3) - 2, .025) and -0.06291503091601201 = (173.36651370458745 - 184.2738732741128) / 173.36651370458745 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Baseline JIT Disasm

Complete output

Compare JIT Disasm

Complete output

JIT Disasm Diff

Link

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@EgorBo
Copy link
Member

EgorBo commented Apr 18, 2023

Most likely dotnet/runtime#84587 (hard to tell due to missing data)

@EgorBo EgorBo closed this as completed Apr 18, 2023
@EgorBo EgorBo removed the untriaged label Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant