Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Changes at 11/17/2021 11:50:34 PM #2481

Closed
performanceautofiler bot opened this issue Nov 23, 2021 · 3 comments
Closed

[Perf] Changes at 11/17/2021 11:50:34 PM #2481

performanceautofiler bot opened this issue Nov 23, 2021 · 3 comments

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Nov 23, 2021

Run Information

Architecture x64
OS ubuntu 18.04
Baseline c3973270d5219607e96db68d7d53f45e88600a55
Compare 8275c379a5c11e006bc6037372a12a2aecc15644
Diff Diff

Regressions in System.Text.RegularExpressions.Tests.Perf_Regex_Common

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Email_IsNotMatch - Duration of single invocation 472.12 ns 798.46 ns 1.69 0.03 True
SplitWords - Duration of single invocation 122.69 μs 184.25 μs 1.50 0.03 True

Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Text.RegularExpressions.Tests.Perf_Regex_Common*'

Payloads

Baseline
Compare

Histogram

System.Text.RegularExpressions.Tests.Perf_Regex_Common.Email_IsNotMatch(Options: IgnoreCase, Compiled)


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 798.4554990079249 > 494.21210129845616.
IsChangePoint: Marked as a change because one of 11/16/2021 12:49:58 PM, 11/23/2021 3:51:55 AM falls between 11/14/2021 12:07:47 PM and 11/23/2021 3:51:55 AM.
IsRegressionStdDev: Marked as regression because -187.63927876660404 (T) = (0 -804.8933315673191) / Math.Sqrt((6.873745422593172 / (25)) + (66.07369264624475 / (23))) is less than -2.0128955989180297 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (25) + (23) - 2, .025) and -0.7053285700117634 = (471.9872438199795 - 804.8933315673191) / 471.9872438199795 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

```#### System.Text.RegularExpressions.Tests.Perf_Regex_Common.SplitWords(Options: None)

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 184.24542620798323 > 128.73112275053325.
IsChangePoint: Marked as a change because one of 11/17/2021 2:42:53 PM, 11/23/2021 3:51:55 AM falls between 11/14/2021 12:07:47 PM and 11/23/2021 3:51:55 AM.
IsRegressionStdDev: Marked as regression because -43.57043331012908 (T) = (0 -179979.49112687304) / Math.Sqrt((2224591.924455732 / (32)) + (39265581.571545586 / (24))) is less than -2.0048792881871513 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (32) + (24) - 2, .025) and -0.4623281025861929 = (123077.36602242084 - 179979.49112687304) / 123077.36602242084 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked as regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@naricc
Copy link

naricc commented Nov 30, 2021

Best guess is that this is also here: dotnet/runtime@25237fa

@naricc naricc self-assigned this Nov 30, 2021
@naricc
Copy link

naricc commented Dec 20, 2021

Looks like this: dotnet/runtime@25237fa

@naricc
Copy link

naricc commented Dec 20, 2021

dotnet/runtime#61972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant