Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Linux/x64: 14 Regressions on 2/7/2024 9:09:09 PM #28996

Open
performanceautofiler bot opened this issue Feb 13, 2024 · 5 comments
Open

[Perf] Linux/x64: 14 Regressions on 2/7/2024 9:09:09 PM #28996

performanceautofiler bot opened this issue Feb 13, 2024 · 5 comments

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Feb 13, 2024

Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline 541857c4678ff26b754dac3326830a835097c449
Compare 2b015648dc114c168232f5e3ba1540ad24bb7895
Diff Diff
Configs CompilationMode:wasm, RunKind:micro

Regressions in System.Globalization.Tests.StringSearch

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
4.98 μs 5.44 μs 1.09 0.11 False
5.01 μs 5.42 μs 1.08 0.15 False
8.60 μs 9.23 μs 1.07 0.07 False
4.90 μs 5.41 μs 1.10 0.16 False
8.61 μs 9.41 μs 1.09 0.06 False
12.94 μs 13.92 μs 1.08 0.07 False
22.58 μs 24.09 μs 1.07 0.05 False
12.64 μs 13.46 μs 1.06 0.10 False
4.86 μs 5.32 μs 1.09 0.11 False
12.99 μs 13.80 μs 1.06 0.07 False
8.55 μs 9.18 μs 1.07 0.06 False
19.56 μs 21.04 μs 1.08 0.05 False
4.94 μs 5.50 μs 1.11 0.16 False
13.06 μs 13.78 μs 1.06 0.09 False

graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Globalization.Tests.StringSearch*'

Payloads

Baseline
Compare

System.Globalization.Tests.StringSearch.IsPrefix_FirstHalf(Options: (, None, True))

ETL Files

Histogram

JIT Disasms

System.Globalization.Tests.StringSearch.IsPrefix_FirstHalf(Options: (en-US, None, True))

ETL Files

Histogram

JIT Disasms

System.Globalization.Tests.StringSearch.IsSuffix_SecondHalf(Options: (en-US, None, True))

ETL Files

Histogram

JIT Disasms

System.Globalization.Tests.StringSearch.IsPrefix_FirstHalf(Options: (, IgnoreCase, True))

ETL Files

Histogram

JIT Disasms

System.Globalization.Tests.StringSearch.IsSuffix_SecondHalf(Options: (, None, True))

ETL Files

Histogram

JIT Disasms

System.Globalization.Tests.StringSearch.IndexOf_Word_NotFound(Options: (pl-PL, None, False))

ETL Files

Histogram

JIT Disasms

System.Globalization.Tests.StringSearch.IsSuffix_SecondHalf(Options: (en-US, IgnoreSymbols, False))

ETL Files

Histogram

JIT Disasms

System.Globalization.Tests.StringSearch.IndexOf_Word_NotFound(Options: (en-US, IgnoreSymbols, False))

ETL Files

Histogram

JIT Disasms

System.Globalization.Tests.StringSearch.IsPrefix_FirstHalf(Options: (pl-PL, None, False))

ETL Files

Histogram

JIT Disasms

System.Globalization.Tests.StringSearch.IndexOf_Word_NotFound(Options: (en-US, IgnoreCase, True))

ETL Files

Histogram

JIT Disasms

System.Globalization.Tests.StringSearch.IsSuffix_SecondHalf(Options: (pl-PL, None, False))

ETL Files

Histogram

JIT Disasms

System.Globalization.Tests.StringSearch.IsPrefix_FirstHalf(Options: (en-US, IgnoreSymbols, False))

ETL Files

Histogram

JIT Disasms

System.Globalization.Tests.StringSearch.IsPrefix_FirstHalf(Options: (en-US, IgnoreCase, True))

ETL Files

Histogram

JIT Disasms

System.Globalization.Tests.StringSearch.IndexOf_Word_NotFound(Options: (, IgnoreCase, True))

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@radekdoulik
Copy link
Member

range is dotnet/runtime@2b01564...e6b5da2

@akoeplinger @pavelsavara could that be caused by your changes?

@pavelsavara
Copy link
Member

My change is just affecting JS and possibly startup. The regression here is specific to string operations. I don't see the connection.
Alex's change is for windows host and this linux.
The third change is just CoreCLR.

I don't get it, this more like ICU related or something. Was there bump in the VM ? Say version of V8 or chrome ?

@radekdoulik
Copy link
Member

@DrewScoggins were there any infra changes around that time?

@lewing should we already see both, the v8 and the chrome bumps as runtime commits?

@lewing
Copy link
Member

lewing commented Feb 14, 2024

I'm not sure if dotnet/performance is using the runtime version of chrome yet. @radical what version is being used here?

@radical
Copy link
Member

radical commented Feb 14, 2024

Yeah, it will be using the chrome version from runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants