Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasm AOT runs not autofiled #2824

Closed
LoopedBard3 opened this issue Jan 9, 2023 · 10 comments
Closed

Wasm AOT runs not autofiled #2824

LoopedBard3 opened this issue Jan 9, 2023 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@LoopedBard3
Copy link
Member

It appears that the following check has not been auto-filing correctly:

Specific Check: Tuesday Check
Run Labels: refs/heads/main, x64, Ubuntu1804, RunKind=micro, CompliationMode=wasm, AOT=true, WASM
and
Specific Check: Tuesday Check
Run Labels: refs/heads/main, x64, Ubuntu1804, RunKind=micro, CompliationMode=wasm, WASM

The run results are showing up in the tables. Investigating the autofile runs to see if they directly failed or if something else is going on.

@LoopedBard3 LoopedBard3 added the bug Something isn't working label Jan 9, 2023
@radical
Copy link
Member

radical commented Jan 9, 2023

cc @lewing

@lewing
Copy link
Member

lewing commented Jan 9, 2023

I think this is because dotnet/performance is targeting net7.0 still and the workaround we used to make it use the net8 runtimes for wasm was disabled so the tests have just been targeting a stable build of the runtime

@lewing
Copy link
Member

lewing commented Jan 9, 2023

The change that caused the workaround to break things went in on December 9th so without manual work this is going to leave us with a month long (Since December 9th) hole in the net8 runtime data for wasm across some fairly important changes.

@DrewScoggins
Copy link
Member

I am doing testing on these changes as we speak. If everything works I will check in the change in the performance repo.

I think this is because dotnet/performance is targeting net7.0 still and the workaround we used to make it use the net8 runtimes for wasm was disabled so the tests have just been targeting a stable build of the runtime

How many big changes and when did they go in? We could go back and run some builds around the major changes that happened so that we can go back and fill in with the correct data going forward.

@lewing
Copy link
Member

lewing commented Jan 9, 2023

@kg which jiterperter commits are most important to have data on?

@kg
Copy link
Member

kg commented Jan 9, 2023

Before and after dotnet/runtime#78493 would be a valuable diff to have.
dotnet/runtime#79239 and dotnet/runtime#80197 are also worth measuring the impact of

@lewing
Copy link
Member

lewing commented Jan 9, 2023

dotnet/runtime#79302 would be nice
dotnet/runtime#80059

check regressions from
dotnet/runtime#75012

@lewing
Copy link
Member

lewing commented Jan 10, 2023

where is the `compliationmode" typo coming from in the labels now? (see #2750)

@DrewScoggins
Copy link
Member

This came from a typo that I had about 4 years ago when I was first putting the lab together. Since then, we have never been able to fully purge it from the system, and because of the way that trends are correlated it is challenging to go back and fix old labels.

@LoopedBard3
Copy link
Member Author

Fixed by: #2816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants