-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mono-LLVM is not tested? #2912
Comments
Despite the LLVM false label, the AOT lanes for mono should both be using LLVM. We need to fix the label. Or it broke and stopped running LLVM? |
Actually if the perf lanes some how stopped using LLVM it would explain this regression that we can't repro: dotnet/perf-autofiling-issues#11536 |
Maybe it used to use LLVM JIT (that was disabled in Mono some time ago)? |
Right now the Mono AOT lanes are configured as |
Base64 is expected to be vectorized, something happend with mono on Jan5 and that benchmark regressed. I assume it's the same issue. Commit range: dotnet/runtime@9197fd5...92d7381 |
@EgorBo |
From what I see we currently have two AOT runs for Mono https://pvscmdupload.blob.core.windows.net/reports/allTestHistory/TestHistoryIndexIndex.html
Both don't look like they use LLVM since I know that Mono-LLVM implements S.R.I intrinsics and is expected to benefit when we vectorize something new. Recently, I've vectorized Guid.ToString and it demonstrated visible benefits on CoreCLR:
While for Mono-AOT runs there were no changes. The only explanation for that is that IsSuppored path were not taken:
cc @naricc @fanyang-mono @DrewScoggins
The text was updated successfully, but these errors were encountered: