Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mono-LLVM is not tested? #2912

Open
EgorBo opened this issue Feb 22, 2023 · 6 comments
Open

Mono-LLVM is not tested? #2912

EgorBo opened this issue Feb 22, 2023 · 6 comments

Comments

@EgorBo
Copy link
Member

EgorBo commented Feb 22, 2023

From what I see we currently have two AOT runs for Mono https://pvscmdupload.blob.core.windows.net/reports/allTestHistory/TestHistoryIndexIndex.html

Both don't look like they use LLVM since I know that Mono-LLVM implements S.R.I intrinsics and is expected to benefit when we vectorize something new. Recently, I've vectorized Guid.ToString and it demonstrated visible benefits on CoreCLR:
image

While for Mono-AOT runs there were no changes. The only explanation for that is that IsSuppored path were not taken:

image
image

cc @naricc @fanyang-mono @DrewScoggins

@naricc
Copy link

naricc commented Feb 22, 2023

Despite the LLVM false label, the AOT lanes for mono should both be using LLVM. We need to fix the label. Or it broke and stopped running LLVM?

@naricc
Copy link

naricc commented Feb 22, 2023

Actually if the perf lanes some how stopped using LLVM it would explain this regression that we can't repro: dotnet/perf-autofiling-issues#11536

@EgorBo
Copy link
Member Author

EgorBo commented Feb 22, 2023

Maybe it used to use LLVM JIT (that was disabled in Mono some time ago)?
Anyway, the main problem in this issue is that if ((Ssse3.IsSupported || AdvSimd.Arm64.IsSupported) && BitConverter.IsLittleEndian) is never taken in Mono

@fanyang-mono
Copy link
Member

Right now the Mono AOT lanes are configured as LLVM AOT with mini JIT fallback. If the method were AOT'ed, then you should see the performance difference. If it falls back go JIT, then there is no LLVM. LLVM JIT was turned off after we integrated LLVM14.

@EgorBo
Copy link
Member Author

EgorBo commented Feb 22, 2023

@fanyang-mono
Copy link
Member

@EgorBo AdvSimd.Arm64.IsSupported is true only when it is LLVM full AOT mode. Currentlhy, we are not running microbenchmarks with full aot mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants