-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Perf] Windows/x64: Regressions in System.IO.Compression #4318
Comments
Likely due to: dotnet/runtime#104454 Improvements are listed in the PR dotnet/runtime#104454 Other regressions:
|
I also ran microbenchmarks in a variety of machines and I got these results myself, which I posted here: The maintainers of zlib-ng shared some cases where regressions are expected, starting with this comment and a few more underneath: dotnet/runtime#102403 (comment) But I have a question: Why am I seeing the exact same values between baseline and compare? |
That seems like a bug with the report generation, we will take a look into it. The numbers in the table on this issue look correct though so I would use those for the baseline value. You should also be able to get specific points after clicking on the graph in the report and hovering over the spot you want the value for. |
Almost certainly you are seeing the same values for baseline and compare because you are looking at the all test history pages that we generate. When we added support for that we just used our existing report template, and it was designed for generating reports with different baseline and compare values. Hope this makes sense. |
Run Information
Regressions in System.IO.Compression.Deflate
Test Report
Repro
General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md
System.IO.Compression.Deflate.Compress(level: Fastest, file: "sum")
ETL Files
Histogram
JIT Disasms
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in System.IO.Compression.Gzip
Test Report
Repro
General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md
System.IO.Compression.Gzip.Compress(level: Fastest, file: "sum")
ETL Files
Histogram
JIT Disasms
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
The text was updated successfully, but these errors were encountered: