Update the Benchmarks.Droid app to use built in Android GetExternalFilesDir #25015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lesDir as a location to save tests to.
|
Hey there @LoopedBard3! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jonathanpeppers
previously approved these changes
Sep 30, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jonathanpeppers
approved these changes
Oct 1, 2024
Redth
approved these changes
Oct 1, 2024
jfversluis
approved these changes
Oct 1, 2024
StephaneDelcroix
approved these changes
Oct 1, 2024
PureWeen
approved these changes
Oct 1, 2024
samhouts
added
the
fixed-in-net8.0-nightly
samhouts
added
the
fixed-in-net9.0-nightly
rmarinho
pushed a commit
that referenced
this pull request
Oct 16, 2024
…lesDir (#25015) * Update the Benchmarks.Droid app to use built in Android GetExternalFilesDir as a location to save tests to. * Update src/Core/tests/Benchmarks.Droid/MainInstrumentation.cs --------- Co-authored-by: Jonathan Peppers <jonathan.peppers@gmail.com>
rmarinho
pushed a commit
that referenced
this pull request
Oct 16, 2024
…lesDir (#25015) * Update the Benchmarks.Droid app to use built in Android GetExternalFilesDir as a location to save tests to. * Update src/Core/tests/Benchmarks.Droid/MainInstrumentation.cs --------- Co-authored-by: Jonathan Peppers <jonathan.peppers@gmail.com>
samhouts
added
fixed-in-9.0.12
and removed
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Update the Benchmarks.Droid app to use built in Android GetExternalFilesDir as a location to save tests to. This will fix the test runs of this done as part of dotnet/performance testing. This also needs to be backported to net9.0.
Issues Fixed
We started hitting an issue where the hardcoded file location was not accessible due to permission errors. This switches to using the built in Android GetExternalFilesDir to get the same path which has corrected the permission error.
Fixes: dotnet/performance#4477
FYI @jonathanpeppers