Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop stripping whitespace #512

Closed
4 tasks
davkean opened this issue Sep 27, 2016 · 5 comments
Closed
4 tasks

Stop stripping whitespace #512

davkean opened this issue Sep 27, 2016 · 5 comments
Assignees
@333fred
Labels
Area-External-CPS Owned by CPS and not this repo. Likely be closed in lieu of issue filed against VS platform. Feature-Project-File-Editing Editing the project either while open in Visual Studio, or via other mechanism. Needs-CPS-work Changes are needed in the closed-source Common Project System (CPS) repo. Tracking Tracking a bug against another repo or a larger thematic issue tracking a group of work.
Milestone
15.0 RTM

Comments

@davkean
Copy link
Member

davkean commented Sep 27, 2016 •
edited
Loading

We should react this to this MSBuild change in CPS: dotnet/msbuild#1036 (comment)

  • Make sure we don't remove blank line at end of file
  • Make sure we don't remove byte order mark
  • Make sure we don't reformat comments
  • Make sure we don't stip whitespace
@davkean davkean added Feature Request Request for a new feature, or new scenario to be handled. Needs-CPS-work Changes are needed in the closed-source Common Project System (CPS) repo. Feature-Project-File-Editing Editing the project either while open in Visual Studio, or via other mechanism. labels Sep 27, 2016
@davkean davkean added this to the 1.0 RC milestone Sep 27, 2016
@srivatsn
Copy link
Contributor

srivatsn commented Sep 27, 2016 •
edited
Loading

Should this be filed in the CPS repo?

@davkean
Copy link
Member Author

davkean commented Sep 27, 2016 •
edited
Loading

I like to have a tracking bug on our side.

@davkean davkean added the Tracking Tracking a bug against another repo or a larger thematic issue tracking a group of work. label Sep 27, 2016
@srivatsn srivatsn removed the Feature Request Request for a new feature, or new scenario to be handled. label Sep 28, 2016
@srivatsn srivatsn modified the milestones: 1.0 RC3, 1.0 RC2 Nov 4, 2016
@davkean
Copy link
Member Author

davkean commented Nov 15, 2016

We haven't reacted to this?

@333fred 333fred mentioned this issue Nov 20, 2016
Closed
@srivatsn srivatsn modified the milestones: 1.0 RC3, 1.0 RC2 Nov 21, 2016
@davkean davkean mentioned this issue Nov 24, 2016
Closed
@srivatsn srivatsn assigned 333fred and unassigned davkean Jan 3, 2017
@333fred 333fred mentioned this issue Jan 6, 2017
Closed
@srivatsn srivatsn added the Area-External-CPS Owned by CPS and not this repo. Likely be closed in lieu of issue filed against VS platform. label Jan 6, 2017
@333fred
Copy link
Member

333fred commented Jan 13, 2017

Some of the work for this is done, but there's still a CPS change needed. It won't be in for RC3.

@333fred 333fred modified the milestones: 1.0 RTM, 1.0 RC3 Jan 13, 2017
@333fred 333fred mentioned this issue Jan 20, 2017
Merged
@333fred
Copy link
Member

333fred commented Jan 20, 2017

Fixed with #1266.

@333fred 333fred closed this as completed Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@333fred 333fred

Labels
Area-External-CPS Owned by CPS and not this repo. Likely be closed in lieu of issue filed against VS platform. Feature-Project-File-Editing Editing the project either while open in Visual Studio, or via other mechanism. Needs-CPS-work Changes are needed in the closed-source Common Project System (CPS) repo. Tracking Tracking a bug against another repo or a larger thematic issue tracking a group of work.
Projects
None yet
Milestone
15.0 RTM
Development

No branches or pull requests
3 participants
@srivatsn @davkean @333fred