Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading roslyn bits causing version downgrades, needs further investigation #8652

Closed
maryamariyan opened this issue Apr 28, 2023 · 1 comment · Fixed by #8764
Closed

Upgrading roslyn bits causing version downgrades, needs further investigation #8652

maryamariyan opened this issue Apr 28, 2023 · 1 comment · Fixed by #8764
Assignees
Milestone

Comments

@maryamariyan
Copy link
Member

maryamariyan commented Apr 28, 2023

Currently upgrading roslyn bits for dotnet/razor is a manual process and it used to be a straightforward upgrade as seen in #8443. In contrast dotnet/runtime has it automatically using bot to upgrade dotnet/runtime#85460

The PR #8492 made changes to add explicit dependencies and explicit properties that match those dependencies into the repo. This is required for source-build to work correctly.

Currently getting the dependencies and resolution aren't very straightforward and upgrading roslyn bits causing version downgrades, needs further investigation.

cc @NikolaMilosavljevic

@ghost ghost added the untriaged label Apr 28, 2023
@NikolaMilosavljevic
Copy link
Member

Dependencies can be easily upgraded using darc. Here's a command that would make the necessary changes in all required files, i.e. Version.details.xml and Versions.props:

darc update-dependencies --channel ".NET Core Tooling Dev" --source-repo roslyn --version 4.7.0-1.23226.15

Regarding package downgrade - this would be unrelated to the changes I made for source-build. Every package upgrade could cause a conflict with versions of transitive dependencies. The fix usually requires updating the version of the offending dependency. Here's an example of a fix for a similar issue I recently did: microsoft/vstest@37acc70

@phil-allen-msft phil-allen-msft added this to the 17.7 P2 milestone May 4, 2023
@ghost ghost removed the untriaged label May 4, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants