Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should validate the syntax for platform names #4015

Closed
terrajobst opened this issue Aug 13, 2020 · 3 comments
Closed

We should validate the syntax for platform names #4015

terrajobst opened this issue Aug 13, 2020 · 3 comments

Comments

@terrajobst
Copy link
Member

terrajobst commented Aug 13, 2020

This related to dotnet/runtime#45851. We should also provide definition-site diagnostics if the syntax of the string passed to the attributes isn't of a valid platform name followed by an optional version.

Note: We don't need to handle the universal methods OperatingSystem.IsPlatform() and OperatingSystem.IsPlatformAtLeast() because the version is a separate argument and dotnet/runtime#45851 will validate that the platform name is known.

@carlossanlop
Copy link
Member

@buyaa-n @terrajobst was this approved in an API proposal in the runtime repo? If yes, can you please link the issue number?

@buyaa-n
Copy link
Contributor

buyaa-n commented Dec 9, 2020

@terrajobst sorry, i am not sure what is this issue adding the proposal in dotnet/runtime#45851, i must be missing something. It seems to me this is covered by dotnet/runtime#45851

@buyaa-n
Copy link
Contributor

buyaa-n commented Mar 4, 2021

Solved with #4838

@buyaa-n buyaa-n closed this as completed Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants