Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making code fix testing include analyzer testing #173

Open
sharwell opened this issue Aug 30, 2018 · 1 comment · May be fixed by #331
Open

Consider making code fix testing include analyzer testing #173

sharwell opened this issue Aug 30, 2018 · 1 comment · May be fixed by #331
Labels
Area-MS.CA.Testing Microsoft.CodeAnalysis.Testing

Comments

@sharwell
Copy link
Member

Currently the following packages are independent of each other:

  • Microsoft.CodeAnalysis.CSharp.Analyzer.Testing.XUnit
  • Microsoft.CodeAnalysis.CSharp.CodeFix.Testing.XUnit
  • Microsoft.CodeAnalysis.VisualBasic.Analyzer.Testing.XUnit
  • Microsoft.CodeAnalysis.VisualBasic.CodeFix.Testing.XUnit

We should consider making the Analyzer packages a dependency of the associated CodeFix package to reduce the number of dependencies users must declare in the project file. See microsoft/vs-threading@498f20d for an example.
@sharwell sharwell added the Area-MS.CA.Testing Microsoft.CodeAnalysis.Testing label Mar 2, 2019
sharwell added a commit to sharwell/roslyn-sdk that referenced this issue May 29, 2019
@sharwell
Add package references from code fix testing to analyzer testing
b6dc209 
Fixes dotnet#173
@sharwell sharwell linked a pull request May 29, 2019 that will close this issue
Open
@sharwell
Copy link
Member Author

sharwell commented May 3, 2021

After the first release, we can merge the packages, and we can use type forwarding in the final release of the code fix package to help users in the upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-MS.CA.Testing Microsoft.CodeAnalysis.Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add package references from code fix testing to analyzer testing sharwell/roslyn-sdk
1 participant
@sharwell