Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WithStatements not working with VB #17753

Closed
kentcb opened this issue Mar 12, 2017 · 6 comments
Closed

WithStatements not working with VB #17753

kentcb opened this issue Mar 12, 2017 · 6 comments
Labels
Area-IDE Concept-API This issue involves adding, removing, clarification, or modification of an API. help wanted The issue is "up for grabs" - add a comment if you are interested in working on it Question
Milestone

Comments

@kentcb
Copy link
Contributor

kentcb commented Mar 12, 2017

NOTE: completely open to this being something I'm doing wrong. I am not at all 💯 sure this is a Roslyn issue. However, the code does work for C#, just not VB.

Version Used: 1.3.2

Steps to Reproduce:

See exact code here. If you grab the entire project and run this specific test, you'll see that it fails. The output does not include any code in the generated method.

Expected Behavior:

Calling WithStatements against SyntaxGenerator should work with VB as it does with C#.

Actual Behavior:

Calling WithStatements against VB's SyntaxGenerator does not appear to append the statements in any way.

@gafter gafter added Area-Analyzers Area-Compilers Concept-API This issue involves adding, removing, clarification, or modification of an API. Question and removed Area-Analyzers labels Mar 12, 2017
@gafter
Copy link
Member

gafter commented Feb 9, 2018

Moving to IDE, as SyntaxGenerator is in the Workspaces layer.

@CyrusNajmabadi
Copy link
Member

Hi @kentcb Can you provide a minimal repro that demonstrates the issue? Thanks!

@kentcb
Copy link
Contributor Author

kentcb commented Feb 11, 2018

@CyrusNajmabadi Afraid not. I submitted this issue nearly a year ago. I've linked to relevant code though.

@jinujoseph jinujoseph added this to the Unknown milestone Feb 12, 2018
@CyrusNajmabadi
Copy link
Member

The issue here is that we only have a VB FunctinStatement. We will need to convert these to their block forms in order to add statements here.

@CyrusNajmabadi CyrusNajmabadi added the help wanted The issue is "up for grabs" - add a comment if you are interested in working on it label Mar 15, 2020
@CyrusNajmabadi
Copy link
Member

Making as help-wanted. We would take a PR here to help with this scenario.

@CyrusNajmabadi
Copy link
Member

Closing out due to lack of feedback.

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Oct 21, 2024
@dotnet dotnet locked and limited conversation to collaborators Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area-IDE Concept-API This issue involves adding, removing, clarification, or modification of an API. help wanted The issue is "up for grabs" - add a comment if you are interested in working on it Question
Projects
None yet
Development

No branches or pull requests

4 participants