Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename project file designator from NullableContextOptions to NullableReferenceTypes #34759

Closed
cartermp opened this issue Apr 4, 2019 · 2 comments
Closed

Rename project file designator from NullableContextOptions to NullableReferenceTypes #34759

cartermp opened this issue Apr 4, 2019 · 2 comments
Labels
Area-Compilers New Language Feature - Nullable Reference Types Nullable Reference Types Urgency-Soon
Milestone
16.2

Comments

@cartermp
Copy link
Contributor

cartermp commented Apr 4, 2019

<NullableContextOptions > feels like we're leaking an implementation detail. Even if the valid values that can be passed in are the same, the bulk will be enable or disable, so it should probably just be called <NullableReferenceTypes>.
@jcouv jcouv added this to the 16.2 milestone Apr 23, 2019
@jcouv
Copy link
Member

jcouv commented Apr 23, 2019

Please let us know when the decision is firm and we'll start executing on it (probably for 16.2). I'm not sure who all needs to be involved (probably a thread including LDM would be good).

@jcouv
Copy link
Member

jcouv commented May 4, 2019

We landed on "Nullable" for the name.
Subsumed by #35432

@jcouv jcouv closed this as completed May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers New Language Feature - Nullable Reference Types Nullable Reference Types Urgency-Soon
Projects
None yet
Milestone
16.2
Development

No branches or pull requests
4 participants
@agocke @gafter @cartermp @jcouv