Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion test helper TestState.SendBackspace is broken #49861

Closed
tmat opened this issue Dec 9, 2020 · 0 comments
Closed

Completion test helper TestState.SendBackspace is broken #49861

tmat opened this issue Dec 9, 2020 · 0 comments
Assignees
@genlu
Labels
Area-IDE Disabled Test Test Test failures in roslyn-CI
Milestone
16.9

Comments

@tmat
Copy link
Member

tmat commented Dec 9, 2020

See disabled test TestReferenceDirective. The last assertion fails because GetCompletionContextWorkerAsync receives incorrect snapshot and trigger:

session.TextView is {?_v4_[0..60)_' class C { # r } (notice no ", which is correct)
triggerLocation.Snapshot is {version: 1 lines: 6 length: 61 content: \r\nclass C\r\n{\r\n # r \"\r\n}\r\n } (should not include " that has been deleted by SendBackspace).
trigger.Reason is Insertion (should be Deletion)
@tmat tmat added Area-IDE Test Test failures in roslyn-CI Disabled Test labels Dec 9, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Dec 9, 2020
@jinujoseph jinujoseph removed the untriaged Issues and PRs which have not yet been triaged by a lead label Dec 9, 2020
@jinujoseph jinujoseph added this to the 16.9 milestone Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@genlu genlu

Labels
Area-IDE Disabled Test Test Test failures in roslyn-CI
Projects
None yet
Milestone
16.9
Development

No branches or pull requests
4 participants
@tmat @genlu @jinujoseph @Dotnet-GitSync-Bot