Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EditAndContinueMethodDebugInformation.Create overload that takes compressedStateMachineStateMap #61636

Closed
tmat opened this issue Jun 1, 2022 · 4 comments
Closed

Add EditAndContinueMethodDebugInformation.Create overload that takes compressedStateMachineStateMap #61636

tmat opened this issue Jun 1, 2022 · 4 comments
Assignees
@tmat
Labels
api-approved API was approved in API review, it can be implemented Area-Compilers Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature Request
Milestone
17.3

Comments

@tmat
Copy link
Member

tmat commented Jun 1, 2022 •
edited
Loading

Background and Motivation

Required to support adding/removing await expressions and yield return statements during EnC.
Added by #61356.

Proposed API

namespace Microsoft.CodeAnalysis.Emit;

public class EditAndContinueMethodDebugInformation
{
  public static EditAndContinueMethodDebugInformation Create(
   ImmutableArray<byte> compressedSlotMap,
   ImmutableArray<byte> compressedLambdaMap);

+ public static EditAndContinueMethodDebugInformation Create(
+   ImmutableArray<byte> compressedSlotMap,
+   ImmutableArray<byte> compressedLambdaMap,
+   ImmutableArray<byte> compressedStateMachineStateMap);
}

Usage Examples

https://github.com/dotnet/roslyn/blob/main/src/Features/Core/Portable/EditAndContinue/EditAndContinueMethodDebugInfoReader.cs#L96
@tmat tmat added Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature Request labels Jun 1, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 1, 2022
@tmat
Copy link
Member Author

tmat commented Jun 1, 2022

@333fred FYI

@333fred 333fred added the api-ready-for-review API is ready for review, it is NOT ready for implementation label Jun 1, 2022
@tmat tmat mentioned this issue Jun 6, 2022
Merged
2 tasks
@tmat tmat added this to the 17.3 milestone Jun 8, 2022
@tmat tmat removed the untriaged Issues and PRs which have not yet been triaged by a lead label Jun 8, 2022
@chsienki
Copy link
Contributor

API Review Notes

  • Approved

@chsienki chsienki added api-approved API was approved in API review, it can be implemented and removed api-ready-for-review API is ready for review, it is NOT ready for implementation labels Jun 23, 2022
@333fred 333fred removed their assignment Jun 24, 2022
@333fred
Copy link
Member

333fred commented Jun 24, 2022

@tmat is there anything left here?

@tmat
Copy link
Member Author

tmat commented Jun 24, 2022

Nope. Closing.

@tmat tmat closed this as completed Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmat tmat

Labels
api-approved API was approved in API review, it can be implemented Area-Compilers Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature Request
Projects
None yet
Milestone
17.3
Development

No branches or pull requests
3 participants
@tmat @333fred @chsienki