-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port few IDE analyzers/fixers to shared layer to be enabled in CodeStyle NuGet package #41363
Closed
Closed
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
f18cea7
Analyzer and code fixes refactoring
mavasani c3ecec5
Port CSharpMakeStructFieldsWritableDiagnosticAnalyzer and fixer
mavasani 2e32204
Port ConvertSwitchStatementToExpression to CodeStyle layer
mavasani df116e9
Port C# type style analyzers (UseImplicitOrExplicitType) to code styl…
mavasani a6579cc
Port RemoveUnnecessaryImports analyzer/fixer to code style layer
mavasani 2750a86
Merge remote-tracking branch 'upstream/master' into RefactorAnalyzerA…
mavasani 09e77dc
Merge remote-tracking branch 'upstream/master' into RefactorAnalyzerA…
mavasani 493b727
Merge remote-tracking branch 'upstream/master' into RefactorAnalyzerA…
mavasani 2046dbb
Merge remote-tracking branch 'upstream/master' into RefactorAnalyzerA…
mavasani 9297c51
Merge remote-tracking branch 'upstream/master' into RefactorAnalyzerA…
mavasani c4ebb30
Refactor remove unncessary imports service
mavasani 46ef3bb
Disable some nullable related unit tests for CodeStyle layer as they …
mavasani 53fdfe0
Add clarification comment
mavasani 68c74bf
Merge remote-tracking branch 'upstream/master' into RefactorAnalyzerA…
mavasani cc3910c
Remove the last remaining extern alias.
mavasani 677d292
Remove stale xlf files.
mavasani 3e69af5
Revert changes to DocumentBasedFixAllProvider and AbstractFormattingC…
mavasani 1e8b5d0
Remove CodeStyle layer from Compiler.sln due to dependencies on proje…
mavasani f1c5abe
Revert unnecessary code changes
mavasani 26540d4
Project changes to avoid C# and VB CodeStyle unit test projects depen…
mavasani 3050f34
Mark CodeStyle test projects as non-Shipping.
mavasani 868886a
Test code refactoring to avoid C# and VB EditorFeatures UnitTests pro…
mavasani 23dc0c0
Add direct project references in UnitTest projects to please BuildBoss
mavasani f70503d
Fix some more test project references
mavasani 216ab58
Change signature for IncludeDiagnosticDuringFixAll
mavasani fb1940f
Merge remote-tracking branch 'upstream/master' into RefactorAnalyzerA…
mavasani c7a3026
Merge remote-tracking branch 'upstream/master' into RefactorAnalyzerA…
mavasani 86304ff
Merge remote-tracking branch 'upstream/master' into RefactorAnalyzerA…
mavasani 7d7bfc8
Merge remote-tracking branch 'upstream/master' into RefactorAnalyzerA…
mavasani f1b4a01
Delete duplicate file added by automatic merge conflict resolution
mavasani f0ed15e
Merge remote-tracking branch 'upstream/master' into RefactorAnalyzerA…
mavasani 6f9b2ce
Merge remote-tracking branch 'upstream/master' into RefactorAnalyzerA…
mavasani f2f18c0
Fixes from conflicts
mavasani 8e0fe0d
Revert unwanted changes and remove usage of extern aliases
mavasani 7f9d9e1
Use shared resource files in shared projects.
mavasani 1e1b9a7
Revert some unrelated changes
mavasani fee840f
Make analyzer diagnostics in CodeStyle layer be warnings by default.
mavasani d22e50c
Add comment
mavasani 870fa85
Merge remote-tracking branch 'upstream/master' into RefactorAnalyzerA…
mavasani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only change done to Compiler.sln is removing the CodeStyle layer of projects from this solution. Other changes seem to have crept in via the tooling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dotnet/roslyn-compiler This is the only compiler change in this PR