Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache RetargetingParameterSymbol.TypeWithAnnotations to avoid ~8.3% allocations in a trace #69011

Merged
merged 2 commits into from
Jul 15, 2023
Merged

Cache RetargetingParameterSymbol.TypeWithAnnotations to avoid ~8.3% allocations in a trace #69011

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90ec1a6
Cache RetargetingParameterSymbol.TypeWithAnnotations to avoid ~3.5% a…
Youssef1313 Jul 12, 2023
ca72dde
Use Interlocked.CompareExchange along with TypeWithAnnotations.Boxed
Youssef1313 Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/Compilers/CSharp/Portable/Symbols/Retargeting/RetargetingParameterSymbol.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using System.Collections.Generic;
using System.Collections.Immutable;
using System.Diagnostics;
using System.Threading;
using Microsoft.CodeAnalysis.CSharp.Emit;

namespace Microsoft.CodeAnalysis.CSharp.Symbols.Retargeting
Expand All @@ -23,6 +24,8 @@ internal abstract class RetargetingParameterSymbol : WrappedParameterSymbol
/// </summary>
private ImmutableArray<CSharpAttributeData> _lazyCustomAttributes;

private TypeWithAnnotations.Boxed? _lazyTypeWithAnnotations;

protected RetargetingParameterSymbol(ParameterSymbol underlyingParameter)
: base(underlyingParameter)
{
Expand All @@ -38,7 +41,14 @@ public sealed override TypeWithAnnotations TypeWithAnnotations
{
get
{
return this.RetargetingModule.RetargetingTranslator.Retarget(_underlyingParameter.TypeWithAnnotations, RetargetOptions.RetargetPrimitiveTypesByTypeCode);
if (_lazyTypeWithAnnotations is null)
{
Interlocked.CompareExchange(ref _lazyTypeWithAnnotations,
new TypeWithAnnotations.Boxed(this.RetargetingModule.RetargetingTranslator.Retarget(_underlyingParameter.TypeWithAnnotations, RetargetOptions.RetargetPrimitiveTypesByTypeCode)),
null);
}

return _lazyTypeWithAnnotations.Value;
}
}

Expand Down