Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Incorrect exit code when analyzing multiple projects or solutions #1057

Closed
PeterKaszab opened this issue Mar 20, 2023 · 2 comments · Fixed by #1061
Closed

[CLI] Incorrect exit code when analyzing multiple projects or solutions #1057

PeterKaszab opened this issue Mar 20, 2023 · 2 comments · Fixed by #1061
Assignees

Comments

@PeterKaszab
Copy link
Contributor

Product and Version Used:
Roslynator.DotNet.Cli 0.5.0

Steps to Reproduce:
Create 2 projects:

  • The first project contains issues that should be reported by the roslynator analyze command
  • The second project does not contain issues

Run analyze command roslyantor analyze path/to/first.csproj path/to/second.csproj

Actual Behavior:
The exit code will be 0, as the last successful command status will overwrite the previous status in MSBuildWorkspaceCommand.cs

Expected Behavior:
The exit code should be 1

@josefpihrt
Copy link
Collaborator

@PeterKaszab Do you want to make a PR?

@PeterKaszab
Copy link
Contributor Author

@PeterKaszab Do you want to make a PR?

Yes, I will check this issue next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants