RCS0053 false positive when using top-level statements

[xt0rted]

Product and Version Used: 4.1.0

Steps to Reproduce: The full code triggering this can be seen here and a branch with the error is here xt0rted/dotnet-run-script#11.

var parser = new CommandLineBuilder(rootCommand)
    // ...
    .UseExceptionHandler((ex, ctx) =>
    {
        var verbose = ctx.ParseResult.HasOption(GlobalOptions.Verbose);
        var writer = new ConsoleWriter(ctx.Console, consoleFormatProvider, verbose);

        if (verbose)
        {
            writer.Error(ex.ToString());
        }
        else
        {
            writer.Error(ex.Message);
        }
    })
    // ...
    .Build();

Actual Behavior:

The rule flags the arrow function as being formatted incorrectly. The code fix removes the 4 space indent on the lines after the arrow but the rule still flags the block of code as being incorrectly formatted.

If I wrap the block of code in braces the rule no longer flags this piece of code which is why I believe it's related to using top-level statements.

{
    var parser = new CommandLineBuilder(rootCommand)
        // ...
        .UseExceptionHandler((ex, ctx) =>
        {
            var verbose = ctx.ParseResult.HasOption(GlobalOptions.Verbose);
            var writer = new ConsoleWriter(ctx.Console, consoleFormatProvider, verbose);

            if (verbose)
            {
                writer.Error(ex.ToString());
            }
            else
            {
                writer.Error(ex.Message);
            }
        })
        // ...
        .Build();
}

Something else I noticed is the error in my build output says RCS0053: Fix formatting of arguments while the docs say RCS0053: Fix formatting of a list.

Expected Behavior:

Given the config being used I'd expect the formatting of this piece of code to not flag any formatting rules.

[josefpihrt]

Hi,

thanks for the report. I can reproduce this bug and I have a fix for it.

The name "Fix formatting of a list" is general name. In this case it is a list of arguments but It also could be a list of parameters, attributes etc.

[fgimian]

Hey @josefpihrt, was this part of the 4.1.1 release? I started experiencing this issue when switching to top level statements with Roslynator 4.1.1.

Thanks heaps
Fotis

[josefpihrt]

Hi,

Sorry for late answer.

It would be better to open new issue because these comments to closed issue can easily fall into oblivion.

Anyway, it was part if the 4.1.1 release. Unfortunately, you discovered another bug 😄.

This additional bug was fixed with #952.

[fgimian]

Thank you so much. I'll be sure to raise a new issue in the future for such cases, apologies. 😄