From 9db548658b943f7b819428385cbd6304dadcb69a Mon Sep 17 00:00:00 2001 From: rzsc <160726116+rzsc@users.noreply.github.com> Date: Sat, 1 Jun 2024 08:02:19 +0200 Subject: [PATCH] Adjust repro file message for merged test (#102141) * Adjust message about repro file for a merged test For now the script ./src/tests/run.py outputs "Failed to create repro for test" for a failed merged test. But this comment 1288 if assembly_is_merged_tests_run: 1289 # REVIEW: Even if the test is a .dll file or .CMD file and is found, we don't know how to 1290 # build a repro case with it. from ./src/test/run.py script says that for a merged test a repro file should not be created at all. Changing the message "Failed to create repro for test" to "Skipping repro for merged test". * Apply PR code review suggestion --- src/tests/run.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/tests/run.py b/src/tests/run.py index 5f2a90c4468ab..7947fd552837c 100755 --- a/src/tests/run.py +++ b/src/tests/run.py @@ -1300,7 +1300,8 @@ def parse_test_results_xml_file(args, item, item_name, tests, assemblies): "result" : result, "time": time, "test_output": test_output, - "assembly_display_name": display_name + "assembly_display_name": display_name, + "is_merged": assembly_is_merged_tests_run })) if result == "Pass": assembly_info["passed"] += 1 @@ -1408,7 +1409,9 @@ def create_repro(args, env, tests): # Now that the args.repro_location exists under /artifacts # create wrappers which will simply run the test with the correct environment for test in failed_tests: - if test["test_path"] is None: + if test["is_merged"]: + print("Skipping repro for merged test: %s (%s)" % (test["name"], test["assembly_display_name"])) + elif test["test_path"] is None: print("Failed to create repro for test: %s (%s)" % (test["name"], test["assembly_display_name"])) else: debug_env = DebugEnv(args, env, test)