From f1d5cea6cab91618aa62b4238234a207b5e477f9 Mon Sep 17 00:00:00 2001 From: Jan Vorlicek Date: Tue, 12 Dec 2023 20:01:46 +0100 Subject: [PATCH] Fix assert in BaseBucketParamsManager (#95911) The assert was breaking couple of MDBG diagnostic tests. The modulePath was empty in that case and modulePath.IsNormalized() was returning false. --- src/coreclr/vm/dwbucketmanager.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/vm/dwbucketmanager.hpp b/src/coreclr/vm/dwbucketmanager.hpp index 82532aa5b42b4..b0389b04fda38 100644 --- a/src/coreclr/vm/dwbucketmanager.hpp +++ b/src/coreclr/vm/dwbucketmanager.hpp @@ -961,7 +961,7 @@ bool BaseBucketParamsManager::GetFileVersionInfoForModule(Module* pModule, USHOR if (!succeeded) { const SString& modulePath = pPEAssembly->GetPath(); - _ASSERTE(modulePath.IsNormalized()); + _ASSERTE(modulePath.IsEmpty() || modulePath.IsNormalized()); succeeded = !modulePath.IsEmpty() && SUCCEEDED(DwGetFileVersionInfo(modulePath.GetUnicode(), major, minor, build, revision)); } }