Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix behavior of (uint)val in Mono to saturating behavior #100368

Open
khushal1996 opened this issue Mar 27, 2024 · 1 comment
Open

Fix behavior of (uint)val in Mono to saturating behavior #100368

khushal1996 opened this issue Mar 27, 2024 · 1 comment
Labels
area-Codegen-JIT-mono
Milestone
Future

Comments

@khushal1996
Copy link
Contributor

This issue is created to track the discussion in the comment --> #97529 (comment)
PR #97529 changes the behavior of floating point to integer conversions on x86/x64. It allows the conversions to follow saturating behavior which .NET wants to standardize on.

Link to the failing build --> https://github.com/dotnet/runtime/pull/97529/checks?check_run_id=23012453843

@fanyang-mono for tracking this issue.
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 27, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Mar 27, 2024
@teo-tsirpanis teo-tsirpanis removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 29, 2024
@tannergooding
Copy link
Member

Just noting that this applies to all floating point -> integer conversions, they should all saturate under the new behavior we're standardizing against.

@steveisok steveisok added this to the 9.0.0 milestone Jun 14, 2024
@steveisok steveisok removed the untriaged New issue has not been triaged by the area owner label Jun 21, 2024
@steveisok steveisok modified the milestones: 9.0.0, Future Aug 8, 2024
@fanyang-mono fanyang-mono removed their assignment Aug 8, 2024
@tannergooding tannergooding mentioned this issue Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Codegen-JIT-mono
Projects
None yet
Milestone
Future
Development

No branches or pull requests
6 participants
@steveisok @jeffschwMSFT @tannergooding @teo-tsirpanis @khushal1996 @fanyang-mono