Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser][mt] Running Buffers tests in parallel results in OOM #100628

Open
maraf opened this issue Apr 4, 2024 · 2 comments
Open

[browser][mt] Running Buffers tests in parallel results in OOM #100628

maraf opened this issue Apr 4, 2024 · 2 comments
Labels
arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm
Milestone

Comments

@maraf
Copy link
Member

maraf commented Apr 4, 2024

This is active issue - search for

<WasmXHarnessMaxParallelThreads>1</WasmXHarnessMaxParallelThreads>

[FAIL][8] System.Buffers.ArrayPool.Tests.ArrayPoolUnitTests.RentingSpecificLengthsYieldsExpectedLengths(requestedMinimum: 2097152, expectedLength: 2097152)
info: System.OutOfMemoryException : Out of memory
info:    at System.Buffers.ConfigurableArrayPool`1[[System.String, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].Rent(Int32 minimumLength)
info:    at System.Buffers.ArrayPool.Tests.ArrayPoolUnitTests.RentingSpecificLengthsYieldsExpectedLengths(Int32 requestedMinimum, Int32 expectedLength)
info:    at System.Object.InvokeStub_ArrayPoolUnitTests.RentingSpecificLengthsYieldsExpectedLengths(Object , Span`1 )
info:    at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

Running in parallel disabled. Discovered in #98492

It seems that GC is unable to keep up with the traffic.
I wonder if Mono on x64 has the same problem but survives this because of more available memory ?

Log

[19:21:33] info: [FAIL] System.Buffers.ArrayPool.Tests.ArrayPoolUnitTests.RentAndReturnManyOfTheSameSize_NoneAreSame(pool: SharedArrayPool`1 { })
[19:21:33] info: System.OutOfMemoryException : Out of memory
[19:21:33] info:    at System.GC.AllocateArray[Byte](Int32 length, Boolean pinned)
[19:21:33] info:    at System.Buffers.SharedArrayPool`1[[System.Byte, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].Rent(Int32 minimumLength)
[19:21:33] info:    at System.Buffers.ArrayPool.Tests.ArrayPoolUnitTests.RentAndReturnManyOfTheSameSize_NoneAreSame(ArrayPool`1 pool)
[19:21:33] info:    at System.Object.InvokeStub_ArrayPoolUnitTests.RentAndReturnManyOfTheSameSize_NoneAreSame(Object , Span`1 )
[19:21:33] info:    at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

Build Information

Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=643881

{
  "ErrorPattern": ["Out of memory", "test-browser"],
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=643881
Error message validated: [Out of memory test-browser]
Result validation: ❌ Known issue did not match with the provided build.
Validation performed at: 4/16/2024 10:19:20 AM UTC

Report

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 0
@maraf maraf added arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm labels Apr 4, 2024
@maraf maraf added this to the 9.0.0 milestone Apr 4, 2024
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara pavelsavara added the Known Build Error Use this to report build issues in the .NET Helix tab label Apr 16, 2024
@pavelsavara
Copy link
Member

I found it still OOM on MT here

I updated the issue to "known build error "

@pavelsavara pavelsavara removed the Known Build Error Use this to report build issues in the .NET Helix tab label Apr 22, 2024
@pavelsavara pavelsavara modified the milestones: 9.0.0, Future Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm
Projects
None yet
Development

No branches or pull requests

2 participants