Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Follow-up work for #100802 #100893

Open
kg opened this issue Apr 10, 2024 · 1 comment
Open

[wasm] Follow-up work for #100802 #100893

kg opened this issue Apr 10, 2024 · 1 comment
Assignees
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono
Milestone

Comments

@kg
Copy link
Contributor

kg commented Apr 10, 2024

#100802 disabled AOT module probing for interpreted WASM builds, but we should also optimize the code for AOT builds, and if possible, completely prune the irrelevant code from the binary in both configurations. We get ifdefs telling us we're targeting WASM and whether or not we're AOT'd, so it should be possible to strip a lot of code that isn't relevant to the target, and make sure we never call dlopen, never do weird filesystem probing, etc.

@kg kg added the arch-wasm WebAssembly architecture label Apr 10, 2024
@kg kg self-assigned this Apr 10, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 10, 2024
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Apr 10, 2024
@vcsjones vcsjones removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 12, 2024
@lewing lewing added this to the 9.0.0 milestone Apr 13, 2024
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Apr 13, 2024
@lewing lewing modified the milestones: 9.0.0, Future Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono
Projects
None yet
Development

No branches or pull requests

4 participants