-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Perf] Windows/x64: 4 Regressions on 4/11/2024 11:29:08 PM #101134
Comments
Tagging subscribers to this area: @dotnet/area-system-runtime |
We are leaving the performance on the table in JIT_Box helper. It should be possible to structure this helper to have fast and slow paths, similar to how other allocation helpers are structured. JIT_Box is inlined by the JIT for situations that matter, so the perf did not matter much. We are calling it directly now that is changing the equation. |
I'm still investigating, but I think one of the culprits (based on the related worse Mono regression in the exact same two benchmarks) is the introduction of the I'm looking now to see if inlining that branch into the callers where it fixes the regression. |
Fixed by #101137 |
Run Information
Regressions in System.Collections.AddGivenSize<String>
Test Report
Repro
General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md
System.Collections.AddGivenSize<String>.ICollection(Size: 512)
ETL Files
Histogram
JIT Disasms
System.Collections.AddGivenSize<String>.List(Size: 512)
ETL Files
Histogram
JIT Disasms
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in System.Reflection.Invoke
Test Report
Repro
General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md
System.Reflection.Invoke.StaticMethod4_ByRefParams_int_string_struct_class
ETL Files
Histogram
JIT Disasms
System.Reflection.Invoke.StaticMethod5_ByRefParams_int_string_struct_class_bool
ETL Files
Histogram
JIT Disasms
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
The text was updated successfully, but these errors were encountered: