Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cdac-build-tool] Take baseline as a command line argument #101257

Open
Tracked by #99298
lambdageek opened this issue Apr 18, 2024 · 1 comment
Open
Tracked by #99298

[cdac-build-tool] Take baseline as a command line argument #101257

lambdageek opened this issue Apr 18, 2024 · 1 comment
Assignees
Labels
area-Diagnostics-coreclr enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@lambdageek
Copy link
Member

Follow-up work item for #100650. In the above PR we made cdac-build-tool take a CDAC_BASELINE("name") preprocessor macro to encode the baseline into the data blob in the object file that we scrape.

There's no need to do that, and it also introduces complications in future scenarios when there's multiple object files (produced by a C/C++ compiler and the NativeAOT compiler, for example): we now need all of them to agree about the baseline.

Instead we should take the baseline name as an optional command line argument and update CMakeLists.txt to pass in an appropriate (possibly platform-specific) one.

This is relatively low-priority because the initial workflow is using an empty baseline.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 18, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Apr 18, 2024
Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@vcsjones vcsjones removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 19, 2024
@tommcdon tommcdon added the enhancement Product code improvement that does NOT require public API changes/additions label Apr 23, 2024
@tommcdon tommcdon added this to the 9.0.0 milestone Apr 23, 2024
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Apr 23, 2024
@tommcdon tommcdon modified the milestones: 9.0.0, 10.0.0 Jul 23, 2024
@lambdageek lambdageek assigned steveisok and unassigned lambdageek Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Diagnostics-coreclr enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

No branches or pull requests

5 participants