-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NI_AdvSimd_Store* use of gtNewSimdStoreNode() #102347
Comments
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
I think all Store-like operations were GT_HWINTRINSIC all the way in JIT untill recently we started to import some of them as |
Right, we changed the standard loads/stores to use In order for |
For You could transform it to If you were to do that for Arm64, we'd want to also do similar x64 around the various |
Thanks for the additional context @tannergooding . My initial thought was we are missing some correctness areas by not doing |
@SwapnilGaikwad PTAL |
Today
NI_AdvSimd_Store
usesgtNewSimdStoreNode()
which eventually gets generated in genCodeForStoreInd(). This has extra code, for example, isvolatile checks.Meanwhile
NI_AdvSimd_StoreSelectedScalar
imports like a normal hwintrinsic and gets generated inhwintrinsiccodegenarm64.cpp
. This is the same for the various other stores.Doulb check why we do not use
genCodeForStoreInd
for other stores as well?Discussion: #102262 (comment)
The text was updated successfully, but these errors were encountered: