-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nativeaot/SmokeTests/Exceptions failing with Assertion failed: (n_heaps <= heap_number) || !gc_t_join.joined()
#103839
Comments
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
Tagging subscribers to this area: @dotnet/gc |
Looks like a DATAs race condition. @dotnet/gc Could you please take a look? Note that nativeaot\SmokeTests\Exceptions test is explicitly opted into server GC to get some coverage for server GC during default CI run. |
Are there any dumps available? I can't seem to find them. Tried to repro locally to no avail. Seems like it's a low probability assertion failure (2 / month). |
Yeah, it doesn't look like infra captured a dump for this. There are 4 hits per month but we don't have any dedicated server GC testing. This is the one and only test we run with server GC enabled. We rely on CoreCLR testing to catch GC bugs right now (even this test is not really testing Server GC - it just tests that setting the csproj property to enable server GC actually enables the server GC). |
@mrsharm @MichalStrehovsky are any dumps available for this, or is there a local repro? |
I couldn't locally repro this and nor could I get to any dumps. My one guess (by a long shot) is that this might be related to the other DATAS race condition we found via Reliability Framework where there is a race in the GetHeap while change_heap_count is invoked but without a dump it's difficult to validate. |
The reliability framework issue was fixed correct? Looks like this issue reproed today. |
It wasn't - I think we were still working on a solution. CC: @Maoni0. |
ah ok. We can tag it as such then, and see if the repro stops after that is fixed. |
I made a fix at #106752. |
@cshung, we should wait some time before confirming this issue has truly fixed - I am observing that the bot is still picking up the same failures. |
@mrsharm, wouldn't the bot reopen it if it finds new failures? I was hoping to confirm the fix by doing that. The builds found from the bot seems to be either 9.0 or two days ago. |
Build Information
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=715849
Build error leg or test failing: nativeaot\SmokeTests\Exceptions\Exceptions\Exceptions.cmd
Pull request: #103821
Error Message
Fill the error message using step by step known issues guidance.
Report
Summary
The text was updated successfully, but these errors were encountered: