Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: SVE Cleanup - Remove unneeded comments from API surface area #104846

Closed
TIHan opened this issue Jul 13, 2024 · 3 comments · Fixed by #105679
Closed

JIT: SVE Cleanup - Remove unneeded comments from API surface area #104846

TIHan opened this issue Jul 13, 2024 · 3 comments · Fixed by #105679
Labels
arch-arm64 area-System.Runtime.Intrinsics arm-sve Work related to arm64 SVE/SVE2 support Priority:2 Work that is important, but not critical for the release
Milestone

Comments

@TIHan
Copy link
Contributor

TIHan commented Jul 13, 2024

In these files:

  • src\libraries\System.Private.CoreLib\src\System\Runtime\Intrinsics\Arm\Sve.PlatformNotSupported.cs
  • src\System\Runtime\Intrinsics\Arm\Sve.cs

There are comments related to the SVE APIs that are not part of the summary blocks.
Example:

        ///  CreateTrueMaskDouble : Set predicate elements to true

        /// <summary>
        /// svbool_t svptrue_pat_b8(enum svpattern pattern)
        ///   PTRUE Presult.B, pattern
        /// </summary>
        public static unsafe Vector<double> CreateTrueMaskDouble([ConstantExpected] SveMaskPattern pattern = SveMaskPattern.All) => CreateTrueMaskDouble(pattern);

We need to remove the /// CreateTrueMaskDouble : Set predicate elements to true line.

@TIHan TIHan added this to the 9.0.0 milestone Jul 13, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 13, 2024
@vcsjones vcsjones added area-System.Runtime.Intrinsics and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 13, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

@jeffhandley jeffhandley added the arm-sve Work related to arm64 SVE/SVE2 support label Jul 28, 2024
@a74nh
Copy link
Contributor

a74nh commented Jul 29, 2024

We need to remove the /// CreateTrueMaskDouble : Set predicate elements to true line.

We just change it to a double quote // CreateTrueMaskDouble : Set predicate elements to true ??

@a74nh
Copy link
Contributor

a74nh commented Jul 30, 2024

priority:2 for RC1 snap : End users will see the API

@a74nh a74nh added the Priority:2 Work that is important, but not critical for the release label Jul 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-arm64 area-System.Runtime.Intrinsics arm-sve Work related to arm64 SVE/SVE2 support Priority:2 Work that is important, but not critical for the release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants