Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EC_KEY from S.S.Cryptography.Native API #105173

Open
krwq opened this issue Jul 20, 2024 · 2 comments
Open

Remove EC_KEY from S.S.Cryptography.Native API #105173

krwq opened this issue Jul 20, 2024 · 2 comments

Comments

@krwq
Copy link
Member

krwq commented Jul 20, 2024

Starting from #104961 we don't really need to keep dependency on EC_KEY anymore and can base all Import/Export APIs solely on EVP_PKEY.

There are couple of advantages of doing this:

Some notes:

  • for full advantage we would need to deprecate IntPtr overloads from (ECDsa|RSA|ECDiffieHellman)OpenSsl - there already exist SafeEvpPKeyHandle which can fully substitute it but it requires some work on the caller
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jul 20, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

@jeffhandley jeffhandley added this to the Future milestone Jul 20, 2024
@jeffhandley jeffhandley removed the untriaged New issue has not been triaged by the area owner label Jul 20, 2024
@bartonjs bartonjs changed the title Remove EC_KEY code from S.S.Cryptography.Native Remove EC_KEY from S.S.Cryptography.Native API Jul 22, 2024
@bartonjs
Copy link
Member

I updated the title to say something closer to the definition of success being removing EC_KEY* from the exported functions signatures.

If we can fully get rid of it, great/fine. But if we still need it to power the import/export APIs on the native side, that's still better than the export/import APIs being in terms of EC_KEY itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants