Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Linux/arm64: 5 Regressions in System.Buffers.Tests.SearchValuesCharTests on 7/22/2024 3:17:40 PM #105488

Closed
performanceautofiler bot opened this issue Jul 25, 2024 · 3 comments · Fixed by #105562
Labels
arch-arm64 area-System.Buffers needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime

Comments

@performanceautofiler
Copy link

Run Information

Name Value
Architecture arm64
OS ubuntu 22.04
Queue AmpereUbuntu
Baseline d285c824a7b240a50c20bf61e0602f3239d76b8c
Compare 47da68b95373df56f8edade7f7736217581c9a3e
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Buffers.Tests.SearchValuesCharTests

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
29.16 ns 38.86 ns 1.33 0.07 True
29.16 ns 41.01 ns 1.41 0.08 True
27.56 ns 38.73 ns 1.41 0.06 False
30.17 ns 37.19 ns 1.23 0.06 False
29.36 ns 42.90 ns 1.46 0.01 True

graph
graph
graph
graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Buffers.Tests.SearchValuesCharTests*'

System.Buffers.Tests.SearchValuesCharTests.LastIndexOfAnyExcept(Values: "abcdefABCDEF0123456789Ü")

ETL Files

Histogram

JIT Disasms

System.Buffers.Tests.SearchValuesCharTests.IndexOfAny(Values: "abcdefABCDEF0123456789Ü")

ETL Files

Histogram

JIT Disasms

System.Buffers.Tests.SearchValuesCharTests.LastIndexOfAny(Values: "abcdefABCDEF0123456789Ü")

ETL Files

Histogram

JIT Disasms

System.Buffers.Tests.SearchValuesCharTests.ContainsAny(Values: "abcdefABCDEF0123456789Ü")

ETL Files

Histogram

JIT Disasms

System.Buffers.Tests.SearchValuesCharTests.IndexOfAnyExcept(Values: "abcdefABCDEF0123456789Ü")

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added arch-arm64 os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels Jul 25, 2024
@LoopedBard3 LoopedBard3 transferred this issue from dotnet/perf-autofiling-issues Jul 25, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 25, 2024
@LoopedBard3
Copy link
Member

LoopedBard3 commented Jul 25, 2024

Likely due to #103216, FYI @MihaZupan

Also seeing this on the x64 win/linux systems, just haven't had a triage covering this timeframe for those systems.

@LoopedBard3 LoopedBard3 changed the title [Perf] Linux/arm64: 5 Regressions on 7/22/2024 3:17:40 PM [Perf] Linux/arm64: 5 Regressions in System.Buffers.Tests.SearchValuesCharTests on 7/22/2024 3:17:40 PM Jul 25, 2024
@stephentoub
Copy link
Member

I think we should revert #103216. At this point I don't think we have sufficient evidence that its pros outweigh the cons.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-buffers
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Jul 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-arm64 area-System.Buffers needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants