Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ios] HybridGlobalization, functions calculating matchLength should return PNSE #106465

Closed
ilonatommy opened this issue Aug 15, 2024 · 4 comments · Fixed by #107390
Closed

[ios] HybridGlobalization, functions calculating matchLength should return PNSE #106465

ilonatommy opened this issue Aug 15, 2024 · 4 comments · Fixed by #107390
Assignees
@mkhamoyan
Labels
area-System.Globalization in-pr There is an active PR which will close this issue when it is merged os-ios Apple iOS
Milestone
10.0.0

Comments

@ilonatommy
Copy link
Member

Follow up PR for iOS based on changes in #105946.

  • IndexOf/LastIndexOf should throw PNSE
  • block tests that throw because of that
  • re-check that docs about it are up to date
@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-System.Globalization os-ios Apple iOS labels Aug 15, 2024
@ilonatommy ilonatommy added this to the 10.0.0 milestone Aug 15, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @ivanpovazan, @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

@mkhamoyan mkhamoyan changed the title [browser] HybridGlobalization, functions calculating matchLength should return PNSE [ios] HybridGlobalization, functions calculating matchLength should return PNSE Aug 15, 2024
@mkhamoyan mkhamoyan removed the arch-wasm WebAssembly architecture label Aug 15, 2024
@vitek-karas
Copy link
Member

@matouskozak

@mkhamoyan mkhamoyan mentioned this issue Sep 5, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Sep 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mkhamoyan mkhamoyan

Labels
area-System.Globalization in-pr There is an active PR which will close this issue when it is merged os-ios Apple iOS
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

[iOS] [HybridGlobalization] Throw PNSE when methods with matchLength are used mkhamoyan/runtime
3 participants
@vitek-karas @ilonatommy @mkhamoyan