Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout at System.Net.Http.Functional.Tests.HttpClientHandlerTest_Http3.SendMoreThanStreamLimitRequestsConcurrently_LastWaits #106596

Closed
lewing opened this issue Aug 18, 2024 · 6 comments · Fixed by #106612
Assignees
Labels
area-System.Net.Http blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' in-pr There is an active PR which will close this issue when it is merged Known Build Error Use this to report build issues in the .NET Helix tab
Milestone

Comments

@lewing
Copy link
Member

lewing commented Aug 18, 2024

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=779538
Build error leg or test failing: System.Net.Http.Functional.Tests.HttpClientHandlerTest_Http3.SendMoreThanStreamLimitRequestsConcurrently_LastWaits
Pull request: https://github.com/dotnet/runtime.git/pull/106589

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "at System.Net.Http.Functional.Tests.HttpClientHandlerTest_Http3.SendMoreThanStreamLimitRequestsConcurrently_LastWaits", 
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=779538
Error message validated: [at System.Net.Http.Functional.Tests.HttpClientHandlerTest_Http3.SendMoreThanStreamLimitRequestsConcurrently_LastWaits]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 8/18/2024 7:42:59 PM UTC

Report

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 0
@lewing lewing added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab labels Aug 18, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Aug 18, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@liveans
Copy link
Member

liveans commented Aug 18, 2024

It's highly likely that this has the same symptom as SendStreamLimitRequestsConcurrently_Succeeds, which was 20 sec timeout and as we've discovered that test was a bit slow when streamLimit:1000 and decided to increase timeout (#103410). We can do the same thing for this as well.

So this is probably test issue, not a product issue.
Moving milestone to 10.0 and if this becomes pain for release/9.0 branches, we can increase timeout over there as well.

/cc @ManickaP

@liveans liveans added this to the 10.0.0 milestone Aug 18, 2024
@liveans liveans removed the untriaged New issue has not been triaged by the area owner label Aug 18, 2024
@ManickaP
Copy link
Member

I agree. Are you gonna put up a PR or should I?

@liveans
Copy link
Member

liveans commented Aug 19, 2024

I agree. Are you gonna put up a PR or should I?

I can do it

@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Aug 19, 2024
@liveans liveans self-assigned this Aug 19, 2024
@ericstj ericstj reopened this Aug 29, 2024
@ericstj
Copy link
Member

ericstj commented Aug 29, 2024

This issue is still being hit in release builds. Can you port your change to release/9.0?

@liveans
Copy link
Member

liveans commented Sep 30, 2024

This issue is still being hit in release builds. Can you port your change to release/9.0?

This is ported to release/9.0 in #107120.

@liveans liveans closed this as completed Sep 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Http blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' in-pr There is an active PR which will close this issue when it is merged Known Build Error Use this to report build issues in the .NET Helix tab
Projects
None yet
4 participants