Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested types do not respect TypeNameParseOptions.MaxNodes #106991

Closed
jkotas opened this issue Aug 26, 2024 · 3 comments · Fixed by #106334
Closed

Nested types do not respect TypeNameParseOptions.MaxNodes #106991

jkotas opened this issue Aug 26, 2024 · 3 comments · Fixed by #106334
Assignees
@adamsitnik
Labels
area-System.Reflection.Metadata binaryformatter-migration Issues related to the removal of BinaryFormatter and migrations away from it in-pr There is an active PR which will close this issue when it is merged
Milestone
9.0.0

Comments

@jkotas
Copy link
Member

jkotas commented Aug 26, 2024

Repro

TypeName.Parse("A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A+A")

Expected result

Fails with InvalidOperationException due to default MaxNodes count exceeded

Actual result:

Parses successfully.

Context: #103713 (comment)
@jkotas jkotas added area-System.Reflection.Metadata binaryformatter-migration Issues related to the removal of BinaryFormatter and migrations away from it labels Aug 26, 2024
@jkotas jkotas added this to the 9.0.0 milestone Aug 26, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'binaryformatter-migration': @adamsitnik, @bartonjs, @jeffhandley, @terrajobst

@jkotas
Copy link
Member Author

jkotas commented Aug 26, 2024

PR with the fix: #106334

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata
See info in area-owners.md if you want to be subscribed.

@jkotas jkotas mentioned this issue Aug 26, 2024
Merged
@terrajobst terrajobst linked a pull request Aug 27, 2024 that will close this issue
[TypeName] Nested types should respect MaxNode count #106334
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Aug 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@adamsitnik adamsitnik

Labels
area-System.Reflection.Metadata binaryformatter-migration Issues related to the removal of BinaryFormatter and migrations away from it in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

[TypeName] Nested types should respect MaxNode count adamsitnik/runtime
2 participants
@adamsitnik @jkotas