Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzing workflow is not friendly to rebuild and incremental changes. #107204

Closed
ericstj opened this issue Aug 30, 2024 · 4 comments · Fixed by #108555
Closed

Fuzzing workflow is not friendly to rebuild and incremental changes. #107204

ericstj opened this issue Aug 30, 2024 · 4 comments · Fixed by #108555
Labels
area-Meta in-pr There is an active PR which will close this issue when it is merged
Milestone

Comments

@ericstj
Copy link
Member

ericstj commented Aug 30, 2024

I noticed that the fuzzing workflow runs as a self-contained app, which means that it requires a full repo build and will have incremental build challenges since self-contained apps rely on restoring nuget packages.

I see that as a result of this, the fuzzing infrastructure defines it's own NuGet.config with a local packages cache and pointers to the output packages. That means any time someone rebuilds they need to delete that cache and rebuild the entire repo to produce those packages.

Can you make it a framework dependent app instead, similar to how all our regular tests work, and use the test shared framework?

That's optimized for local builds and incremental changes - rebuilding libraries will update the test sharedframework without any extra steps.

@MihaZupan

@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Aug 30, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@julealgon
Copy link

...the fuzzing workflow...

@ericstj could you please clarify what exactly do you mean by this "fuzzing workflow"? I've not heard that term before so I'm honestly curious now. I have no idea what mechanism you are talking about here.

Is it some internal thing only used inside of this runtime repo?

@ericstj
Copy link
Member Author

ericstj commented Aug 30, 2024

These steps: https://github.com/dotnet/runtime/blob/main/src/libraries/Fuzzing/README.md

@ericstj ericstj added area-Meta and removed area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner labels Sep 3, 2024
@ericstj ericstj added this to the 10.0.0 milestone Sep 3, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Meta in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants