Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf] Windows/x64: 1 Regression from ldsfld quirk change #109348

Open
performanceautofiler bot opened this issue Oct 29, 2024 · 4 comments
Open

[Perf] Windows/x64: 1 Regression from ldsfld quirk change #109348

performanceautofiler bot opened this issue Oct 29, 2024 · 4 comments
Assignees
@EgorBo
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-windows runtime-coreclr specific to the CoreCLR runtime
Milestone
10.0.0

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Oct 29, 2024 •
edited by DrewScoggins
Loading

No description provided.

@performanceautofiler performanceautofiler bot added arch-x64 os-windows runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels Oct 29, 2024
@performanceautofiler PerformanceAutoFiler
Copy link
Author

performanceautofiler bot commented Oct 29, 2024 •
edited by DrewScoggins
Loading

Run Information

Name Value
Architecture x64
OS Windows 10.0.22621
Queue TigerWindows
Baseline 061941a4e3dacd3e35c42e397386e0ab70b86f2e
Compare a09ad52948af961a91ad56e4375135cc5a39d5f2
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Numerics.Tests.Perf_Vector3

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
2.13 ns 3.76 ns 1.76 0.05 True

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Numerics.Tests.Perf_Vector3*'

System.Numerics.Tests.Perf_Vector3.TransformByQuaternionBenchmark

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot mentioned this issue Oct 29, 2024
Closed
@DrewScoggins DrewScoggins transferred this issue from dotnet/perf-autofiling-issues Oct 29, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 29, 2024
@DrewScoggins DrewScoggins changed the title [Perf] Windows/x64: 30 Regressions on 10/22/2024 2:53:19 AM [Perf] Windows/x64: 1 Regression from ldsfld quirk change Oct 29, 2024
@DrewScoggins
Copy link
Member

DrewScoggins commented Oct 29, 2024 •
edited
Loading

Likely due to: #108606
Regression: Linux x64 - dotnet/perf-autofiling-issues#43924
Windows x64 AMD Regressions: dotnet/perf-autofiling-issues#43929
Linux x64 AMD Regressions: dotnet/perf-autofiling-issues#43950

Improvements:
Windows x64 AMD Improvements: dotnet/perf-autofiling-issues#43938
Linux x64 AMD Improvements: dotnet/perf-autofiling-issues#43956
Linux x64 Intel Improvements: dotnet/perf-autofiling-issues#43946

@jeffschwMSFT jeffschwMSFT added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 30, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@vcsjones vcsjones removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 30, 2024
@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Nov 6, 2024
@JulieLeeMSFT JulieLeeMSFT added this to the 10.0.0 milestone Nov 6, 2024
@JulieLeeMSFT
Copy link
Member

@EgorBo, PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EgorBo EgorBo

Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-windows runtime-coreclr specific to the CoreCLR runtime
Projects
None yet
Milestone
10.0.0
Development

No branches or pull requests
5 participants
@vcsjones @EgorBo @DrewScoggins @jeffschwMSFT @JulieLeeMSFT