Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R2RDump - Fix coredistools dependency in build #13122

Closed
nattress opened this issue Jul 22, 2019 · 4 comments
Closed

R2RDump - Fix coredistools dependency in build #13122

nattress opened this issue Jul 22, 2019 · 4 comments
Labels
area-R2RDump-coreclr Ready-to-run image dump tool
Milestone
6.0.0

Comments

@nattress
Copy link
Contributor

nattress commented Jul 22, 2019 •
edited by trylek
Loading

The architecture-specific coredistools.dll is not copied to the build output for R2RDump and has to be done manually to get disassembly. This should happen as part of the build - we should be publishing r2rdump, not just building it, since that deploys NuGet runtime dependencies.
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the 5.0 milestone Jan 31, 2020
@davidwrighton davidwrighton modified the milestones: 5.0.0, 6.0.0 Jul 30, 2020
@davidwrighton
Copy link
Member

While this would be nice, we don't need this for .NET 5. Moving to 6.0

@trylek trylek changed the title R2RDump - Fix cordistools dependency in build R2RDump - Fix coredistools dependency in build Sep 8, 2020
@trylek trylek mentioned this issue Sep 12, 2020
Merged
@mangod9
Copy link
Member

mangod9 commented Jul 10, 2021

@cshung believe this issue is resolved, or is there some more work required?

@cshung
Copy link
Member

cshung commented Jul 10, 2021

@cshung believe this issue is resolved, or is there some more work required?

I did nothing for this bug - but it appears that the issue is probably fixed in #44490 by @echesakovMSFT

In particular, I do see coredistools.dll is placed in the right directory at the build output, if that is all we wanted, I think we can close this bug.

@mangod9
Copy link
Member

mangod9 commented Jul 12, 2021

Ok closing for now, we can reopen if some OS/arch are still broken.

@mangod9 mangod9 closed this as completed Jul 12, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-R2RDump-coreclr Ready-to-run image dump tool
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
5 participants
@nattress @cshung @msftgits @davidwrighton @mangod9