Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembly version of Microsoft.CSharp and System.Runtime.CompilerServices.Unsafe in 5.0 is older than the ones in 3.1? #1918

Closed
yyjdelete opened this issue Jan 19, 2020 · 7 comments · Fixed by #2264

Comments

@yyjdelete
Copy link

Tested with nightly builds of netcoreapp5.0, this will make app use out of box assembly instead of inbox ones when they are reference from other place.

Seems they are the only two assembly which have older version:

Microsoft.CSharp: 4.0.4 in 5.0, and 4.0.5 in 3.1 and nuget(4.7.0)
System.Runtime.CompilerServices.Unsafe: 4.0.5 in 5.0, and 4.0.6 in 3.1 and nuget(4.7.0)

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jan 19, 2020
@jkotas
Copy link
Member

jkotas commented Jan 19, 2020

cc @ericstj @Pilchie

@ericstj ericstj removed the untriaged New issue has not been triaged by the area owner label Jan 21, 2020
@ericstj ericstj added this to the 5.0 milestone Jan 21, 2020
@ericstj
Copy link
Member

ericstj commented Jan 21, 2020

@Anipik can you review these versioning dependencies?

It looks like you included these in 3.1 changes: dotnet/corefx@eaa4640

But they were missing from 5.0 changes:
dotnet/corefx#41723

@jkoritzinsky
Copy link
Member

This is blocking #2115 which in turn is blocking dotnet/sdk#3884.

@jkotas
Copy link
Member

jkotas commented Jan 29, 2020

The fix was reverted.

@ViktorHofer
Copy link
Member

Fixed by #2354

@yyjdelete
Copy link
Author

@Anipik
Seems the buildin version of System.Runtime.CompilerServices.Unsafe in net5.0(preview) now has two AssemblyRef at the same time: System.Runtime 4.0.0.0 and 5.0.0.0. But it works well and seems nothing is affacted . So is this by design or another issue?

@jkotas
Copy link
Member

jkotas commented Apr 12, 2020

@yyjdelete Thanks for letting us know. I have submitted a fix in #34870

@ericstj ericstj reopened this Apr 13, 2020
@ericstj ericstj closed this as completed Apr 13, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.