WinHttpException should map to WebException Status

[DalSoft]

At the moment to handle transient exceptions cross platform, I'm having to do something special for .NET Standard Windows only (Map the NativeErrorCode to WebExceptionStatus). But for .NET 4.x and Mono I just get the WebExceptionStatus Status from the InnerException.

Here is how Mono does it for iOS
https://github.com/mono/mono/blob/master/mcs/class/System.Net.Http/HttpClientEx.cs

[davidsh]

We have thought about how to improve error handling in HttpClient. HttpWebRequest for example has WebException and WebExceptionStatus enums. This would something for a future release.

HttpClient returns HttpRequestException's. We are thinking about adding a property to that except similar to WebExceptionStatus enum behavior. That is how we would handle cross-platform error codes. We would prefer to make the error handling just rely on a top-level exception property rather than have to use the inner exceptions.

cc: @stephentoub

[davidsh]

This is really a dupe of #15567

[davidsh]

Closing as duplicate of #15567.

[antonfirsov]

@DalSoft sorry for pinging you in this old discussion, but I wonder about your experience with .NET 5.0+ era error handling in HttpClient if you can comment on that. Note that HttpClient / SocketsHttpHandler throws specific exceptions for Socket/URI/DNS/SSL errors and #21965 has been addressed in #2281. Is this sufficient, or do have some scenarios we can improve?

[DalSoft]

@DalSoft sorry for pinging you in this old discussion, but I wonder about your experience with .NET 5.0+ era error handling in HttpClient if you can comment on that. Note that HttpClient / SocketsHttpHandler throws specific exceptions for Socket/URI/DNS/SSL errors and #21965 has been addressed in #2281. Is this sufficient, or do have some scenarios we can improve?

The retry code in my RestClient covers all the cases I'm aware off.

https://github.com/DalSoft/DalSoft.RestClient/blob/master/DalSoft.RestClient/Handlers/RetryHandler.cs