Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValueTuple should use readonly methods #29403

Open
benaadams opened this issue Apr 28, 2019 · 3 comments
Open

ValueTuple should use readonly methods #29403

benaadams opened this issue Apr 28, 2019 · 3 comments
Labels
area-System.Runtime enhancement Product code improvement that does NOT require public API changes/additions
Milestone
Future

Comments

@benaadams
Copy link
Member

E.g. Equals, GetHashCode etc

/cc @tannergooding
@tannergooding
Copy link
Member

More specific instance of https://github.com/dotnet/corefx/issues/36586.

It would probably be good to blanket cover Equals, GetHashCode, and ToString for all mutable structs

@bartonjs
Copy link
Member

I've assigned this to Future because #1718 is assigned to Future. It sort of feels like this one should just be closed in favor of that one; but if there's value to having this one separate (and on a different milestone) then I'm curious as to what it is 😄.

@msftgits msftgits transferred this issue from dotnet/corefx Feb 1, 2020
@msftgits msftgits added this to the Future milestone Feb 1, 2020
@jkotas
Copy link
Member

jkotas commented Feb 1, 2020

E.g. Equals, GetHashCode etc

Is it going to result into same type of subtle breaking change as what we have hit with Nullable<T> ? #23969 (comment)

@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@joperezr joperezr added enhancement Product code improvement that does NOT require public API changes/additions and removed untriaged New issue has not been triaged by the area owner labels Jul 2, 2020
@jozkee jozkee mentioned this issue Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-System.Runtime enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
Future
Development

No branches or pull requests
7 participants
@benaadams @maryamariyan @jkotas @msftgits @tannergooding @bartonjs @joperezr