String IgnoreCase extension method

[BluePositive]

How about to split the Equals String extension method in 2 Equals() and EqualsIgnoreCase()
each should a have a default behavior and accepts a new Comparison Enum like the StringComparison Enum that has only 3 values

1. CurrentCulture
2. InvariantCulture
3. Ordinal

as a parameter (like Equals() now)
I think it will make it easier to use for most cases (and more likely to be noticed with an IDE )

[Gnbrkm41]

Duplicate of https://github.com/dotnet/corefx/issues/649?

[Gnbrkm41]

I don't understand what you mean by "you can alter it by passing a StringComparison Enum". Does that mean that your proposed EqualsIgnoreCase should accept StringComparison as the second parameter? at that point might as well as just use the existing Equals method.

[BluePositive]

@Gnbrkm41 I edited the title to make it more understandable.

[Gnbrkm41]

So, are you suggesting that your suggestion would be used like:

str1.EqualsIgnoreCase(str2, StringComparison.Ordinal)

and it's better than

str1.Equals(str2, StringComparison.OrdinalIgnoreCase)

?

[BluePositive]

@Gnbrkm41 in most cases it will be

str1.EqualsIgnoreCase(str2)

and that is more straightforward than

str1.Equals(str2, StringComparison.OrdinalIgnoreCase)

[Gnbrkm41]

1. Why does this has to be an extension method? might as well as add it as an instance method if it's going to be useful for discoverability.

2. I think there's a potential concern with the default culture; every other instance methods (e.g. IndexOf, Compare etc...) use current culture when not specified. This suggestion does not however and use Ordinal, and this would break the tradition of defaulting to culture sensitive comparison. Unless people read the documents (which usually people don't), they would assume that this is culture sensitive, case insensitive comparison. Apparently I was thinking that string.Equals(string) defaults to current culture when its not. 😅

3. If it's expected to be used without the second parameter for the most case, why bother providing one at all? I think we could just have EqualsIgnoreCase(string) one. It seems rather weird to be able to also specify case insensitivity by StringComparison. (e.g. str1.EqualsIgnorecase(str2, StringComparison.OrdinalIgnoreCase)

p.s: if we're going to add this as an instance method, I think #14065 suits better.

[BluePositive]

@Gnbrkm41

1. You're right it does not need to be an extension method.
2. About your issue about the second parameter, my suggestion is that it shouldn't need the second
   parameter only if you want to change the default.
3. About your issue with passing a StringComparison.OrdinalIgnoreCase I edit the issue to create a new enum that accepts only 3 values without the IgnoreCase values